Skip to content

Harden branding image symlink check to cover ancestor directories #3261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Mpdreamz merged 1 commit into from
May 6, 2026
+4 −2
Merged

Harden branding image symlink check to cover ancestor directories #3261

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/Elastic.Documentation.Configuration/Builder/ConfigurationFile.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
using Elastic.Documentation.Diagnostics;
using Elastic.Documentation.Extensions;
using Elastic.Documentation.Links;
using static Elastic.Documentation.Configuration.SymlinkValidator;

namespace Elastic.Documentation.Configuration.Builder;

Expand Down Expand Up @@ -330,10 +331,11 @@ private static BrandingConfiguration ValidateBranding(BrandingConfiguration bran
return null;
}

if (resolved.LinkTarget is not null)
var symlinkError = ValidateFileAccess(resolved, context.DocumentationSourceDirectory);
if (symlinkError is not null)
{
context.EmitError(context.ConfigurationPath,
$"'{fieldName}' path '{imagePath}' is a symbolic link, which is not allowed for branding images.");
$"'{fieldName}' path '{imagePath}' is unsafe: {symlinkError}");
return null;
}

Expand Down
Loading