[Rule Tuning] Suricata and Elastic Defend Network Correlation - #6763
Merged
Merged
Conversation
|
⛔️ Test failed Results
|
eric-forte-elastic
requested review from
Aegrah,
Mikaayenson,
imays11,
sodhikirti07,
terrancedejesus and
w0rk3r
September 10, 2026 18:09
eric-forte-elastic
marked this pull request as ready for review
September 10, 2026 18:10
5 tasks
Mikaayenson
approved these changes
Sep 10, 2026
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The change is a straightforward rule-tuning adjustment removing an invalid field reference and updating metadata, with no other functional modifications.
Pull request overview
This PR tunes an existing cross-platform EQL correlation rule to align with updated ECS/integration field restrictions by removing a Suricata-side filter that referenced an ECS field not populated by the Suricata integration.
Changes:
- Updated rule metadata
updated_dateto reflect the tuning date. - Removed the
source.domainexclusion from the Suricata portion of the EQL sequence to avoid referencing an unavailable field.
File summaries
| File | Description |
|---|---|
| rules/cross-platform/command_and_control_suricata_elastic_defend_c2.toml | Removes unsupported source.domain predicate from the Suricata clause and updates rule metadata date. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
terrancedejesus
approved these changes
Sep 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Issue link(s):
Related to #6491
Summary - What I changed
Small tuning PR to reconcile a cross platform rule with our updated ECS restrictions. Previously, it appeared that
source.domainwas present in Suricata, but it is not. See #6491 (comment) and https://github.com/elastic/ia-trade-team/issues/1036 for more detail.How To Test
Verify in telemetry and test against #6491.
Checklist
bug,enhancement,schema,maintenance,Rule: New,Rule: Deprecation,Rule: Tuning,Hunt: New, orHunt: Tuningso guidelines can be generatedmeta:rapid-mergelabel if planning to merge within 24 hoursContributor checklist