Skip to content

[Rule FN Tuning] System V Init Script Created - #6758

Merged
Aegrah merged 4 commits into
mainfrom
sysv-init-tuning
Sep 11, 2026
Merged

Aegrah merged 4 commits into
mainfrom
sysv-init-tuning

Conversation

@Aegrah

@Aegrah Aegrah commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

Summary

Tuning this rule to also trigger on /etc/init and /etc/inittab(2) file creations. This stems from a false negative observed within the Gafgyt malware family.

image

@Aegrah Aegrah self-assigned this Sep 10, 2026
Copilot AI lite review requested due to automatic review settings September 10, 2026 07:33
@elastic-vault-github-plugin-prod

elastic-vault-github-plugin-prod Bot commented Sep 10, 2026

Copy link
Copy Markdown

⛔️ Test failed

Results
  • ❌ System V Init Script Created (eql)
    • coverage_issue: no_rta
    • stack_validation_failed: no_rta

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The new /etc/init match likely misses creations under the /etc/init/ directory, and the rule’s narrative/Osquery transforms are now out of sync with the expanded detection scope.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

This PR tunes the existing Linux persistence rule “System V Init Script Created” to reduce false negatives (notably observed with Gafgyt) by expanding the file creation paths it matches beyond /etc/init.d/.

Changes:

  • Updated rule metadata updated_date to 2026/09/10.
  • Expanded the EQL file path match from only /etc/init.d/* to also include /etc/init and /etc/inittab*.
File summaries
File Description
rules/linux/persistence_init_d_file_creation.toml Expands the rule’s file path matching and updates the rule’s updated_date to reflect the tuning.
Review details

Suppressed comments (1)

rules/linux/persistence_init_d_file_creation.toml:157

  • The rule scope now includes /etc/init and /etc/inittab*, but the description, investigation guide text, and Osquery listing transforms still describe only /etc/init.d/; this can confuse triage and lead to irrelevant Osquery output for alerts on the new paths.
and file.path like ("/etc/init.d/*", "/etc/init", "/etc/inittab*") and
not (
  • Files reviewed: 1/1 changed files
  • Comments generated: 1
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread rules/linux/persistence_init_d_file_creation.toml Outdated
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@elastic-vault-github-plugin-prod

elastic-vault-github-plugin-prod Bot commented Sep 10, 2026

Copy link
Copy Markdown

⛔️ Test failed

Results
  • ❌ System V Init Script Created (eql)
    • coverage_issue: no_rta
    • stack_validation_failed: no_rta

Comment thread rules/linux/persistence_init_d_file_creation.toml Outdated
Comment thread rules/linux/persistence_init_d_file_creation.toml

@eric-forte-elastic eric-forte-elastic left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment, otherwise looks good to me 👍

Aegrah and others added 2 commits September 11, 2026 09:58
Co-authored-by: Eric Forte <119343520+eric-forte-elastic@users.noreply.github.com>
@elastic-vault-github-plugin-prod

elastic-vault-github-plugin-prod Bot commented Sep 11, 2026

Copy link
Copy Markdown

⛔️ Test failed

Results
  • ❌ System V Init Script Created (eql)
    • coverage_issue: no_rta
    • stack_validation_failed: no_rta

@elastic-vault-github-plugin-prod

elastic-vault-github-plugin-prod Bot commented Sep 11, 2026

Copy link
Copy Markdown

⛔️ Test failed

Results
  • ❌ System V Init Script Created (eql)
    • coverage_issue: no_rta
    • stack_validation_failed: no_rta

@Aegrah
Aegrah merged commit e89fb92 into main Sep 11, 2026
13 checks passed
@Aegrah
Aegrah deleted the sysv-init-tuning branch September 11, 2026 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants