Skip to content

fix(eloot): v2.11.9 massive boulders skinned with the wrong tool type - #2469

Closed
mrhoribu wants to merge 1 commit into
elanthia-online:masterfrom
mrhoribu:fix/eloot-skin-massive-boulder
Closed

mrhoribu wants to merge 1 commit into
elanthia-online:masterfrom
mrhoribu:fix/eloot-skin-massive-boulder

Conversation

@mrhoribu

Copy link
Copy Markdown
Contributor

Summary

  • `Loot.skin` routes stone-hided creatures (krynch, stone mastiff, krag dweller, cavern urchin) to the blunt-weapon skinner instead of the default blade, since a blade doesn't work on their hides.
  • `massive boulder` is the same kind of stone-hided creature but was missing from both the blunt-match and the blunt-exclude regex, so it fell through to the regular (bladed) skinner.
  • Added it to both regexes so it's routed to the blunt skinner like its fellow stone-hided creatures.

Test plan

  • bundle exec rubocop scripts/eloot.lic — no offenses
  • bundle exec rspec spec/scripts/eloot_spec.rb — 134 examples, 0 failures

🤖 Generated with Claude Code

Loot.skin routes krynch, stone mastiff, krag dweller, and cavern urchin
to the blunt-weapon skinner since a blade doesn't work on their hides,
but left massive boulder out of that list despite it being the same
kind of stone-hided creature, so it fell through to the regular skinner.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Sep 13, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: e67ce486-1dc0-4c1e-9880-bb627dc379bd

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@mrhoribu

Copy link
Copy Markdown
Contributor Author

Closing — this fix is being folded into #2467 instead.

@mrhoribu mrhoribu closed this Sep 13, 2026
@mrhoribu
mrhoribu deleted the fix/eloot-skin-massive-boulder branch September 13, 2026 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant