Skip to content

feat(egemhoarder): v2.2.0 combine jars, single_jar option, bounty command - #2468

Closed
mrhoribu wants to merge 2 commits into
elanthia-online:masterfrom
mrhoribu:feat/egemhoarder-jar-improvements
Closed

mrhoribu wants to merge 2 commits into
elanthia-online:masterfrom
mrhoribu:feat/egemhoarder-jar-improvements

Conversation

@mrhoribu

@mrhoribu mrhoribu commented Sep 13, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Add a combine command that merges duplicate partial jars of the same gem in bin into one, using live jar contents rather than cached data.
  • Deposit now keeps filling additional jars from chest in the same run instead of stopping after the first one fills.
  • Add a single_jar config option (;egemhoarder config single_jar true|false): when on, every gem is capped at one jar per locker, and any extra of that gem is left in the gemsack rather than starting a second jar.
  • Add a bounty command that reads the active gem bounty via Lich's Bounty API (Bounty.task.type/.gem/.number) instead of scraping checkbounty text, checks how many of that gem are already in the gemsack, and if short, raids the known locker holding the most of that gem. Leaves accepting the assignment and selling/turning in to the jeweler NPC to ebounty/eloot, matching how those scripts already divide the work.
  • Switch locker navigation to go2's CHE-aware "locker" target (Lich >= 5.12.2), falling back to the old publiclockers tag on older Lich versions.
  • Track each known locker's room id (locker_rooms) alongside its location name so bounty (and future callers) can navigate to a specific known locker instead of only ever the nearest one.
  • raid now takes gem_name/count as explicit parameters instead of reading Script.current.vars itself, so bounty can call it directly.

Test plan

  • ruby -c scripts/egemhoarder.lic
  • rubocop scripts/egemhoarder.lic — no offenses
  • bundle exec rspec — full suite green (no existing egemhoarder spec)
  • Manual in-game verification of combine, the multi-jar deposit loop, bounty, and the go2 "locker" routing (not exercised live)

🤖 Generated with Claude Code

…gle_jar option

Adds a combine command to merge duplicate partial jars of the same gem
in bin, makes deposit keep filling additional jars in one run instead
of stopping after the first fills, and adds a single_jar config option
to cap every gem at one jar per locker.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Sep 13, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 122eed50-e25f-4aaa-990c-81e7ea12b553

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Adds a bounty command that reads the active gem bounty via Lich's
Bounty API and raids the known locker holding that gem instead of
leaving the player to do it manually. Also switches locker navigation
to go2's CHE-aware "locker" target on Lich >= 5.12.2, falling back to
the old publiclockers tag on older versions, and tracks each known
locker's room id so bounty (and any future caller) can navigate to a
specific locker rather than only the nearest one.

raid() now takes gem_name/count as explicit parameters instead of
reading Script.current.vars itself, so bounty can reuse it directly.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@mrhoribu mrhoribu changed the title feat(egemhoarder): v2.1.0 combine duplicate jars, multi-jar fill, single_jar option feat(egemhoarder): v2.2.0 combine jars, single_jar option, bounty command Sep 13, 2026
@mrhoribu mrhoribu closed this Sep 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant