Conversation
…gle_jar option Adds a combine command to merge duplicate partial jars of the same gem in bin, makes deposit keep filling additional jars in one run instead of stopping after the first fills, and adds a single_jar config option to cap every gem at one jar per locker. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Contributor
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Adds a bounty command that reads the active gem bounty via Lich's Bounty API and raids the known locker holding that gem instead of leaving the player to do it manually. Also switches locker navigation to go2's CHE-aware "locker" target on Lich >= 5.12.2, falling back to the old publiclockers tag on older versions, and tracks each known locker's room id so bounty (and any future caller) can navigate to a specific locker rather than only the nearest one. raid() now takes gem_name/count as explicit parameters instead of reading Script.current.vars itself, so bounty can reuse it directly. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
combinecommand that merges duplicate partial jars of the same gem inbininto one, using live jar contents rather than cached data.chestin the same run instead of stopping after the first one fills.single_jarconfig option (;egemhoarder config single_jar true|false): when on, every gem is capped at one jar per locker, and any extra of that gem is left in the gemsack rather than starting a second jar.bountycommand that reads the active gem bounty via Lich'sBountyAPI (Bounty.task.type/.gem/.number) instead of scrapingcheckbountytext, checks how many of that gem are already in the gemsack, and if short, raids the known locker holding the most of that gem. Leaves accepting the assignment and selling/turning in to the jeweler NPC to ebounty/eloot, matching how those scripts already divide the work."locker"target (Lich >= 5.12.2), falling back to the oldpubliclockerstag on older Lich versions.locker_rooms) alongside its location name sobounty(and future callers) can navigate to a specific known locker instead of only ever the nearest one.raidnow takesgem_name/countas explicit parameters instead of readingScript.current.varsitself, sobountycan call it directly.Test plan
ruby -c scripts/egemhoarder.licrubocop scripts/egemhoarder.lic— no offensesbundle exec rspec— full suite green (no existing egemhoarder spec)combine, the multi-jar deposit loop,bounty, and the go2"locker"routing (not exercised live)🤖 Generated with Claude Code