fix(bigshot.lic): v5.16.0 looting races eloot on resume when both are paused

[mrhoribu]

Summary

• Fixes a rare timing bug in looting_watch: it only checked the watched loot script's pause state, never bigshot's own. When something (e.g. ecleanse) paused bigshot and the loot script back-to-back for a disarm-recovery cast, looting_watch would notice the loot script's pause and hand control back immediately - regardless of whether bigshot itself had also just been paused.
• That let bigshot advance one extra loot iteration and kill the loot script for the next corpse while the current one was independently resuming and finishing its own action, with no reliable ordering between the two. Could skip a loot/skin action or cut one off mid-command. Real session log reproducing it is in the linked work unit.
• Fix: block on bigshot's own pause at the top of the loop (the same idiom used elsewhere in the script) so it can't race ahead while paused.
• Landing as part of v5.16.0 alongside the rest of the stack rather than a separate release, and simplified the v5.16.0 changelog entries to plain language.
• Stacked on docs/bigshot-yard-documentation (docs(bigshot.lic): v5.16.0 add YARD documentation throughout #2417), the tip of the open bigshot PR stack (feat(bigshot.lic): v5.16.0 migrate room-creature targeting to Creature module #2414 -> feat(bigshot.lic): v5.16.0 add crtrStatus command checks, migrate flying/rooted/frozen/prone #2415 -> feat(bigshot.lic): v5.16.0 add ;bigshot help and unknown-option fallback #2416 -> docs(bigshot.lic): v5.16.0 add YARD documentation throughout #2417 -> this).
• Replaces fix(bigshot.lic): v5.16.0 looting races eloot on resume when both are paused #2432, which was opened from a fork and so didn't group into the native stack view; this is the same branch pushed directly to this repo.

Test plan

• New regression spec spec/bigshot/looting_watch_spec.rb, following the source-extraction-and-eval technique from spec/bigshot/priority_spec.rb. Uses a Mutex/ConditionVariable + Queue-based stub instead of sleep-based polling, so the race is deterministic:
  • blocks while bigshot is paused even though the loot script is also paused, and only returns once bigshot is unpaused
  • still breaks immediately on the loot script's own pause once bigshot itself was never paused (no behavior change for the common case)
  • kill/box-in-hand/rest-flag handling after the loop unaffected
• Audited every other Script.paused?/Script.running? call site in bigshot.lic for the same bug shape - none found; this was the only raw polling loop watching another script's state without also checking its own
• bin/migrate run first (gameobj-data fixtures)
• bundle exec rspec - full suite passing
• RBENV_VERSION=4.0.5 rubocop -A - clean

Generated with Claude Code

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 4a7c7234-382d-4d27-859b-21569be50119

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}