Skip to content

fix(eloot) v2.9.8 empty hand if selling box-in-hand - #2361

Merged
Deysh merged 1 commit into
elanthia-online:masterfrom
Deysh:eloot
Jun 17, 2026
Merged

Deysh merged 1 commit into
elanthia-online:masterfrom
Deysh:eloot

Conversation

@Deysh

@Deysh Deysh commented Jun 17, 2026 •

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • Bug Fixes
    • Fixed an issue where ELoot could get stuck with an occupied hand during selling when starting with a box in hand. The script now properly manages hand availability to prevent this blockage.

@coderabbitai

coderabbitai Bot commented Jun 17, 2026 •

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: bade4f8a-055d-4bee-aebb-1c40ba958a5f

📥 Commits

Reviewing files that changed from the base of the PR and between 3b75b2d and aed4afd.

📒 Files selected for processing (1)
  • scripts/eloot.lic

📝 Walkthrough

Walkthrough

Bumps the eloot.lic script version to v2.9.8 and adds logic in ELoot::Sell.box_in_hand to call ELoot::Inventory.free_hands on the non-box hand when that hand is not also holding a box.

Changes

ELoot free-hand fix

Layer / File(s) Summary
free_hands call in box_in_hand and changelog
scripts/eloot.lic
Changelog header updated from v2.9.7 to v2.9.8. In ELoot::Sell.box_in_hand, added conditional calls to ELoot::Inventory.free_hands targeting the non-box hand when that hand does not hold a box.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

  • elanthia-online/scripts#2216: Modifies scripts/eloot.lic with related box/hand targeting and loot behavior changes inside the same selling flow touched by this PR.

Suggested reviewers

  • mrhoribu
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The PR title accurately describes the main change: fixing an issue in eloot v2.9.8 where the script now empties the non-box hand when selling with a box in hand.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Deysh
Deysh merged commit 06282e4 into elanthia-online:master Jun 17, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant