stdenv: support aarch64-darwin - #184
Merged
Merged
Conversation
Collaborator
|
Oh snap! Very nice |
broken, not in scope of corepkgs
Contributor
|
Native validation on
$ nix-instantiate -A stdenv -A freshBootstrapTools.test
error: evaluation aborted with the following error message:
'callPackageWith: Function called without required argument "hello" at
stdenv/darwin/test-bootstrap-tools.nix:6, did you mean "ell"?'
Pausing builds at this failure and watching for a PR update before retrying. |
Contributor
Author
|
yeah thats expected, try nix-build -A git to build most of the deps |
Contributor
|
Thanks, running Live build dashboard — I'll keep watching new commits and comments, report build failures, and retry on new commits. |
Contributor
|
Native build failure on cmake-minimal-3.31.10 Last package log lines: Continuing independent builds with |
qweered
force-pushed
the
support-darwin
branch
2 times, most recently
from
September 9, 2026 16:25
1ac25bd to
45beeeb
Compare
Contributor
|
Build recovery on Previously reported failure. The overall |
Assisted-by: codex with gpt-5.6-sol-high
Contributor
|
Native build failure on ld64-954.16 Last package log lines: Continuing independent builds with |
Collaborator
|
I could have sworn we added hello back. or at least agreed that it's fine to do so |
Contributor
|
Build recovery on Package duration was not recorded for this attempt. Previously reported failure. The overall |
Contributor
Author
I removed it again recently 😅 |
Contributor
|
Human here, I think it is time I created a bot version of myself for GitHub. |
Contributor
Author
|
Agent, restart git build from scratch for latest commit, it should unblock all jobs |
Contributor
|
@qweered Restarted This attempt also records per-package build durations. I’ll report failures and recoveries here. Nixie 🐾 — Srid’s pet build gremlin. |
Contributor
|
Native build failure on gawk-5.3.2 Package build duration: 0m 45s (excludes dependency waiting). Last package log lines: Continuing independent builds with Nixie 🐾 — Srid’s pet build gremlin. |
Contributor
|
Native build failure on make-4.4.1 Package build duration: 0m 29s (excludes dependency waiting). Last package log lines: Continuing independent builds with Nixie 🐾 — Srid’s pet build gremlin. |
Contributor
Author
|
Fixed both builds. Agent: fully restart git build, cleanup failures |
Contributor
|
Build recovery on Package duration was not recorded for this attempt. Previously reported failure. The overall Nixie 🐾 — Srid’s pet build gremlin. |
Contributor
|
Build recovery on Package duration was not recorded for this attempt. Previously reported failure. The overall Nixie 🐾 — Srid’s pet build gremlin. |
Contributor
|
Native build failure on groff-1.23.0 Package build duration: 0m 49s (excludes dependency waiting). Last package log lines: Continuing independent builds with Nixie 🐾 — Srid’s pet build gremlin. |
Contributor
|
Native build failure on opensp-1.5.2 Package build duration: 0m 23s (excludes dependency waiting). Last package log lines: Continuing independent builds with Nixie 🐾 — Srid’s pet build gremlin. |
qweered
force-pushed
the
support-darwin
branch
from
September 9, 2026 19:35
a4259c2 to
d8ed833
Compare
Contributor
|
Native build failure on groff-1.23.0 Package build duration: 0m 39s (excludes dependency waiting). Last package log lines: Continuing independent builds with Nixie 🐾 — Srid’s pet build gremlin. |
Contributor
|
Build recovery on Package build duration: 0m 38s (excludes dependency waiting). Previously reported failure. The overall Nixie 🐾 — Srid’s pet build gremlin. |
qweered
force-pushed
the
support-darwin
branch
from
September 9, 2026 19:48
d8ed833 to
46d5e68
Compare
Contributor
|
Build recovery on Package duration was not recorded for this attempt. Previously reported failure. The overall Nixie 🐾 — Srid’s pet build gremlin. |
Contributor
|
Build recovery on Package duration was not recorded for this attempt. Previously reported failure. The overall Nixie 🐾 — Srid’s pet build gremlin. |
Contributor
Author
|
OK, git builds 🎉. For now its enough, anyone using Darwin please send patches |
qweered
marked this pull request as ready for review
September 9, 2026 19:57
Collaborator
|
Hell yea. let me give it a quick review :) |
jonringer
approved these changes
Sep 10, 2026
Collaborator
There was a problem hiding this comment.
These seem very minor given the scope of the changes, pasting for posterity.
Vague TODO in top-level.nix:1884
Followed by 30+ lines of complex Darwin-specific LLVM override logic that reconstructs the llvm attribute with a completely different code path from Linux. This is the biggest piece of acknowledged debt — the comment gives no indication of what needs fixing. The Darwin LLVM scoping logic is a tangled lib.makeOverridable + lib.fix + manual passthru reconstruction that's fragile and hard to follow.stripDebugFlags="-S" repeated 7 times in stdenv/darwin/default.nix
The identical string with identical comment (# llvm-strip does not support "-p" for Mach-O) is copy-pasted across stages. Should be extracted into a shared binding like commonPreHook already is.aarch64 extraNativeBuildInputs repeated 5 times in stdenv/darwin/default.nix
extraNativeBuildInputs = lib.optionals localSystem.isAarch64 [
prevStage.updateAutotoolsGnuConfigScriptsHook
prevStage.gnu-config
];
Same pattern duplicated across stages 1-4 and xclang.
Medium — AGENTS.md Violations
New updateScript in pkgs-many/libffi/upstream.nix:67
updateScript = nix-update-script { };
AGENTS.md porting guide says to strip updateScript (nixpkgs-only field). This was newly introduced in this PR.New doCheck = false in pkgs-many/libffi/upstream.nix:62
AGENTS.md: "doCheck = false is the default — don't set it explicitly." The comment even has a TODO acknowledging it should move to passthru.FIXME in stdenv/darwin/bootstrap-files/aarch64-apple-darwin.nix:1
FIXME: Changed to arm64-apple-darwin in release.nix stdenvBootstrapTools, please handle when refreshing
Naming mismatch between filename and upstream convention, left unresolved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Still messy and needs cleanup, but better than nixpkgs's implementation