Fix eic-spack-mirror source mirror being dropped during package installation - #410
Merged
Merged
Conversation
11 tasks
wdconinc
approved these changes
Sep 6, 2026
wdconinc
left a comment
Contributor
There was a problem hiding this comment.
Ah, of course, yes. Thanks a lot for digging into this!
wdconinc
enabled auto-merge (squash)
September 6, 2026 18:42
SebastianPaucar
temporarily deployed
to
github-pages
September 6, 2026 19:42 — with
GitHub Actions
Inactive
Contributor
Author
Glad I could help! |
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Briefly, what does this PR introduce? Please link to any relevant presentations or discussions.
This PR adds
eic-spack-mirrortomirrors.yaml.inso it's present in the generated file (mirrors.yaml) that gets mounted incontainers/eic/Dockerfile, and survives into the actualspack install. No SSL errors.This fixes
dawn/dawncut(and any other package relying oneic-spack-mirror) failing to fetch duringspack installin CI.Verified in #388:
eic_xlnow build successfully on amd64, amd64_v3, and arm64 withdawn/dawncutinxl/spack.yaml.What is the urgency of this PR?
What kind of change does this PR introduce?
Please check if any of the following apply