Skip to content

Fix eic-spack-mirror source mirror being dropped during package installation - #410

Merged
wdconinc merged 2 commits into
masterfrom
fix/mirrors-yaml-eic-spack-mirror
Sep 6, 2026
Merged

wdconinc merged 2 commits into
masterfrom
fix/mirrors-yaml-eic-spack-mirror

Conversation

@SebastianPaucar

Copy link
Copy Markdown
Contributor

Briefly, what does this PR introduce? Please link to any relevant presentations or discussions.

This PR adds eic-spack-mirror to mirrors.yaml.in so it's present in the generated file (mirrors.yaml) that gets mounted in containers/eic/Dockerfile, and survives into the actual spack install. No SSL errors.

This fixes dawn/dawncut (and any other package relying on eic-spack-mirror) failing to fetch during spack install in CI.

Verified in #388: eic_xl now build successfully on amd64, amd64_v3, and arm64 with dawn/dawncut in xl/spack.yaml.

What is the urgency of this PR?

  • High (please describe reason below)
  • Medium
  • Low

What kind of change does this PR introduce?

  • Bug fix (issue #__)
  • New feature (issue #__)
  • Optimization (issue #__)
  • Updated documentation
  • other: __

Please check if any of the following apply

  • This PR introduces breaking changes. Please describe changes users need to make below.
  • This PR changes default behavior. Please describe changes below.
  • AI was used in preparing this PR. Please describe usage below.

@SebastianPaucar SebastianPaucar mentioned this pull request Sep 6, 2026
11 tasks

@wdconinc wdconinc left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, of course, yes. Thanks a lot for digging into this!

@wdconinc
wdconinc enabled auto-merge (squash) September 6, 2026 18:42
@github-actions

github-actions Bot commented Sep 6, 2026

Copy link
Copy Markdown

Capybara summary for PR 410

@SebastianPaucar

Copy link
Copy Markdown
Contributor Author

Ah, of course, yes. Thanks a lot for digging into this!

Glad I could help!

@wdconinc
wdconinc merged commit fe55adc into master Sep 6, 2026
90 checks passed
@wdconinc
wdconinc deleted the fix/mirrors-yaml-eic-spack-mirror branch September 8, 2026 19:48

This branch was previously deployed

1 inactive deployment
github-pages — 22e88dd9 Deployed Sep 6, 2026 by SebastianPaucar via deploy-artifacts-page #4004
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants