perf: teak release support#129
Conversation
luisfelipec95
force-pushed
the
lfc/teak-support
branch
from
f348978 to
f3a5718
Compare
magajh
left a comment
magajh
left a comment
There was a problem hiding this comment.
@luisfelipec95 Please check if any of the comments I left in eduNEXT/eox-core#319 apply to this PR as well.
Also, could you please let us know if the test cases have been fully tested and we have made sure everything is working fine?
magajh
left a comment
magajh
left a comment
There was a problem hiding this comment.
@luisfelipec95 have we checked that the workflows are up to date with the latest dependencies?
|
The dependencies are up to date and the test cases were run in the remote environment. |
|
@luisfelipec95 why are the integration tests failing? can we please fix this before merging this PR? |
|
Regarding the workflow error: Currently, eox-tagging uses edx-opaque-keys[django]==2.13.0, which I believe is causing the error. If I update it to version 3.0.0, it creates an incompatibility with eox-core. With the teak release of eox-core, the update to edx-opaque-keys[django]==3.0.0 is also being made. Therefore, once the new release of eox-core is available, I can specify that new version in eox-tagging and update opaque-keys to ==3.0.0. |
@luisfelipec95 great. Let's do the eox-core release first then, and after the dependency is updated here and the tests are passing, I'll approve this PR so we can merge it. |
2 participants
Description
This PR aims to support the new Teak release
Testing instructions
1, Create a Teak environment using Tutor.
2. Install eox-tagging using this branch you can follow the official tutor documentation.
3. Follow the test cases file.