perf: optimize find_all_tags_for with caching and indexing#127
Merged
Conversation
ff6b935 to
12f0b58
Compare
Contributor
Author
|
@eduNEXT/heimdall just so you know these changes were already deployed some time ago to the nimbus saas repository to fix #119, and they are working fine |
|
Hi @magajh thanks a lot for your help! LGTM! |
DeimerM
approved these changes
Nov 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is a backport of the changes made in #126 to solve this issue #119
This PR introduces optimizations to the
find_all_tags_formethod and related functionality to improve performance when working with large datasets in theTagmodel. Specifically:Caching for
ContentTypeLookups:ContentTypeobjects for frequently used model names. This reduces redundant database queries forContentType.objects.get(), especially in high-traffic scenarios or repeated calls.Database Indexes:
target_typeandtarget_object_idfields in theTagmodel.target_typeandtarget_object_id, particularly in thefind_all_tags_formethod.Optimized Query Logic:
list()call ontarget.values_list("id", flat=True)in thefind_all_tags_formethod.Why These Changes Were Made
find_all_tags_formethod was identified as a performance bottleneck, particularly for large datasets in theTagtable (~6 million records).ContentTypelookups were causing unnecessary database queries.target_typeandtarget_object_idlacked an index, leading to slower performance on large datasets.