Adopt the CLI-scaffold-parity component baseline (#11)

[mbreissi]

Summary

Adopts the CLI-scaffold-parity component baseline for telemetry-processor. Per issue #11, this repo
is a processor, not a southbound adapter, so only the cross-cutting baseline applies (no sb/*
verbs, no southbound_health, no device seam, no required panels). Full P0+P1+P2 per the resolved
scope decisions in the master remediation plan (SD-A: full scope; SD-B: commit the lockfile; SD-D:
fix the license mismatch inline).

Checklist (mapped to issue #11)

P0 — correctness of the reproducible build

• 1. Commit Cargo.lock. Dropped the stale /Cargo.lock .gitignore line + rationale;
  regenerated with the local .cargo/config.toml [patch] override inactive so it records the
  pinned git dependency (not a local path); committed. Also unblocks issue Docker: bump the Rust build base off 1.85 (can't build current Cargo.lock) #10 (a Docker build needs
  a lockfile CI can actually see).

P1 — baseline adoption

• 2. CI coverage job. cargo llvm-cov --fail-under-lines 90 added to ci.yml, same feature
  set as the build job (streaming,streaming-file-parquet,streaming-file-avro,scripting-lua). Getting
  there honestly required splitting src/app.rs's untestable EdgeCommons composition root
  (ProcessorApp::start/build_route/run — none of Config/MessagingService/EventsFacade/
  CommandInbox/StreamService has a public test constructor) from the testable fan-out/command
  logic, moved to a new src/dispatch.rs. Added a downstream MessagingService fake
  (src/test_support.rs) and a test-only recording EvtEmitter (mirroring file-replicator's
  Events::recording_events — EventsFacade has the same no-public-constructor constraint). The
  gate excludes only main.rs, app.rs (the genuine composition-root seam), and test_support.rs
  (test-only support code, same treatment file-replicator gives testutil.rs).
• 3. deploy-docs.yml. Added verbatim (modbus-adapter shape) so a docs-only push still
  triggers a site rebuild.
• 4. config.schema.json. Models component.global.defaults (what edgecommons component validate currently checks) plus $defs.route/$defs.stage describing every
  component.instances[] shape (filter/sample/aggregate/project/script, incl. the multi-signal
  inputs/output form) for documentation and forward compatibility. Validated against both shipped
  test-configs/ samples with a real JSON Schema validator (ajv, draft 2020-12) — both pass; a
  typo'd key in either section is rejected.
• 5. Governance files. AGENTS.md, CLAUDE.md (@AGENTS.md import + local-dev note),
  DESIGN.md (decision register D-TP-1..8 seeded from the shipped v2 design + this remediation's own
  decisions).

P2 — enhancements

• 6. Edge-console panels (optional, not required for processors). Implemented rather than
  deferred — straightforward via the library's existing commands.register_panel. Two
  scope: "component" panels: overview (fleet totals + flush/pause/resume) and routes (per-route
  counters via get-stats).
• 7. License reconciliation. Cargo.toml's license = "Apache-2.0" (stale) → "BUSL-1.1"
  (matches the actual LICENSE file and org policy). Fixes #9.
• 10. Stale-comment sweep. The Cargo.toml comment pointing at a ../core-monorepo/libs/rust
  sibling path (the current convention is a gitignored .cargo/config.toml [patch] override at
  ../core/libs/rust) fixed while touching the file.

Validation

• cargo test --locked --features scripting-lua: 96 passed, 0 failed (native Windows and
  WSL/Linux — identical results).
• cargo clippy --all-targets --locked --features scripting-lua -- -D warnings: clean on both
  platforms.
• cargo llvm-cov --locked --features streaming,streaming-file-parquet,streaming-file-avro,scripting-lua --ignore-filename-regex '(app|main|test_support)\.rs' --fail-under-lines 90:
  92.48% line coverage (gate passes), identical on native Windows and WSL/Linux — no undercount
  discrepancy this run.
• Fresh-clone build confirmed: built the committed Cargo.lock in an isolated copy with no ancestor
  .cargo/config.toml override in scope (so it resolves the pinned git rev, exactly as CI/a real
  fresh clone would) — cargo build --locked --all-targets --features scripting-lua succeeds.
• config.schema.json validated against both test-configs/*.json samples with ajv (draft 2020-12).

Deferred validation (per the org matrix, flagged rather than silently skipped): HOST/dual-MQTT,
GG-lab, and Kubernetes live-infra regression were not re-run. This changeset is hygiene/CI-shaped
(lockfile, coverage gate, schema, governance docs, a license fix, a testability-only source split,
and two additive console panels) — it changes no wire contract, config-consuming behavior, or
deployed runtime path, so no live-infra gate applies per the validation matrix.

Deviations from the plan

None. The app.rs/dispatch.rs split was not explicitly called out in the issue, but is a direct,
disciplined consequence of implementing item #2 (the coverage gate) honestly rather than papering
over an untestable composition root with a broad exclusion — recorded as D-TP-7 in DESIGN.md.

Fixes #11
Fixes #9

🤖 Generated with Claude Code

https://claude.ai/code/session_01DxV5wFi7LCratBERVT6aiL

[mbreissi]

Update: addressed an adversarial-review MINOR.

The app.rs coverage exclusion was flagged as broader than a thin live-runtime seam — build_route still contained testable decision branches (target/filter/publish-topic resolution, script-output-topic validation, the restamp policy) that need only a plain Config, not a live EdgeCommons.

Fixed by extracting all of that into a new src/route_build.rs (resolve_global_wiring, resolve_target, resolve_filters, resolve_publish_topic, resolve_script_output_topics, compute_restamp), unit-tested directly against Config::from_value-built configs (11 new tests, ~99% coverage on the new file — no fake needed, since Config has a public test constructor). app.rs now contains only code that must obtain a live Arc<dyn MessagingService>/EventsFacade/Arc<CommandInbox>/Arc<dyn MetricService>/Arc<dyn StreamService> (stream targets only) or gg.shutdown_signal() — none of which has a public/test constructor outside the edgecommons crate, so this residual is a genuine, irreducible seam.

ci.yml's exclusion list is unchanged ((app|main|test_support)\.rs) — route_build.rs is deliberately included, not excluded.

Re-validated: cargo test 107/107 (was 96), cargo clippy -D warnings clean, cargo llvm-cov --fail-under-lines 90 → 92.95% lines (was 92.48%), identical on native Windows and WSL/Linux. Cargo.lock confirmed untouched throughout (still git-sourced at the pinned rev — all cargo invocations for this fix ran in isolated copies outside the worktree, never in-place, to avoid the ancestor .cargo/config.toml [patch] override rewriting it).