You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
No actionable comments were generated in the recent review.
Walkthrough
Mise tasks now invoke external jq, AWK, and yq programs for report generation, deployment limit checks, Dockerignore conversion, and REST Markdown tidying. The changes also add an AWK script for Dart storage declarations and introduce two static-analysis rules.
Changes: Mise task transformations
Layer / File(s)
Summary
SLOC report aggregation and formatting .mise/config.coverage.toml, .mise/sloc-languages.jq, .mise/sloc-table.awk
The SLOC task uses external jq and AWK programs to combine language counts and format the table.
Deployment limit inputs and probe generation .mise/config.toml, .mise/verify-limits-*.yq
The task uses external yq programs to select Deployments, read annotations and rlimits, and generate probe Pods.
The task uses an AWK program to replace <br/> and rewrite schema-unavailable lines.
Dart REST storage rewrite
Layer / File(s)
Summary
Storage-client rewrite and task update .mise/config.dart.toml, .mise/dart-rest-storage.awk
The task configuration removes its inline storage-client rewrite. The new AWK script contains the import and storage declaration rewrites, and fails unless each expected match occurs once.
Multiline inline program rule
Layer / File(s)
Summary
Rule, fixture, and catalogue entry config/semgrep/no-multiline-inline-program.yaml, config/semgrep-tests/no-multiline-inline-program.toml.yaml, config/semgrep/comment-summary-line.yaml, CHECKS.md
The Semgrep rule detects multiline inline programs in mise configurations. Its fixture covers violations and allowed cases. The checks catalogue documents the rule, and comment-summary matching now includes .yq files.
Tuple identity map rule
Layer / File(s)
Summary
Rule, tests, and catalogue entry config/ast-grep/rules/no-tuple-identity-map.yaml, config/ast-grep/tests/no-tuple-identity-map.yaml, CHECKS.md
The ast-grep rule detects tuple identity maps in Rust .map closures. Tests include valid and invalid examples, and the checks catalogue documents the rule.
edge-toolkit/core#168: Adds the gen:rest-md task; this PR changes that task’s output-tidying step.
Suggested reviewers:pierre-tenedero
Merge Risk: Minimal · up to d8ac4
This change moves inline scripts in the build tasks into separate files and adds two lint rules. No concrete problem was found, so it looks safe to merge after the usual checks.
Pre-merge checks: 4
Check name
Status
Explanation
Description Check
Check skipped - CodeRabbit’s high-level summary is enabled.
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Title check
The title "Create separate scripts for mise tasks" matches the main change. The PR moves inline awk, jq, yq, and goawk programs out of mise task definitions into task-named files under .mise/ (for exa…
Full details: Title check
Explanation
The title "Create separate scripts for mise tasks" matches the main change. The PR moves inline awk, jq, yq, and goawk programs out of mise task definitions into task-named files under .mise/ (for example sloc-languages.jq, sloc-table.awk, verify-limits-probe.yq, gitignore-to-dockerignore.awk, rest-md-tidy.awk). It also adds a Semgrep rule and documentation for this practice. The title is specific and concise, and a reviewer scanning history can tell what changed. The PR objectives only say "Split out scripts," which agrees with the title.
Finishing Touches
Generate unit tests (beta)
Commit to this branch
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.
We reviewed changes in 4d43b8a...d8ac4dc on this pull request. Below is the summary for the review, and you can see the individual issues we found as inline review comments.
AI Review is run only on demand for your team. We're only showing results of static analysis review right now. To trigger AI Review, comment @deepsourcebot review on this thread.
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer TIP This summary will be updated as you push new changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
New Features
Improvements
Maintenance