Skip to content

fix: wait legacy projection gap retries in milliseconds, not microseconds (fixes #701) #704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dgafka merged 1 commit into from
Sep 27, 2026
Merged

fix: wait legacy projection gap retries in milliseconds, not microseconds (fixes #701) #704

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion packages/PdoEventSourcing/src/Prooph/GapDetection.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,18 @@ public function getDefinition(): Definition

public function build(): ProophGapDetection
{
return new ProophGapDetection($this->retryConfig, $this->detectionWindow?->build());
return new ProophGapDetection($this->retryDelaysInMicroseconds(), $this->detectionWindow?->build());
}

private function retryDelaysInMicroseconds(): ?array
{
if ($this->retryConfig === null) {
return null;
}

return array_map(
static fn (int $delayInMilliseconds): int => $delayInMilliseconds * 1000,
$this->retryConfig,
);
}
}
11 changes: 11 additions & 0 deletions packages/PdoEventSourcing/tests/Integration/GapDetectionInSynchronousProjectionTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,6 +120,17 @@ public function test_detecting_gaps_with_detection_window(): void
);
}

public function test_retry_delays_are_waited_in_milliseconds_before_skipping_gap(): void
{
$ecotone = $this->bootstrapEcotoneWithGapDetection(new GapDetection([0, 300], new DateInterval('PT60S')));

$startedAt = microtime(true);
$ecotone->sendCommand(new CloseTicket('124'));
$elapsedMilliseconds = (microtime(true) - $startedAt) * 1000;

self::assertGreaterThanOrEqual(300, $elapsedMilliseconds);
}

public function test_running_projection_without_gap_detection(): void
{
$ecotone = $this->bootstrapEcotoneWithGapDetection(null);
Expand Down
Loading