Repository navigation
Conversation
Fixes eclipse-threadx#475 Defining NX_DISABLE_PACKET_CHAIN in nx_user.h removes packet-link fields, but CMake still compiled MQTT, WebSocket, RTP, and NetX Secure. CMake now detects the setting, disables fragmentation, and excludes components that require packet chaining. It also provides options to select this build or omit all add-ons and NetX Secure. The no-chain tests use the same source set. Cortex-M7 GNU 14.2.1/Ninja builds passed with the macro in nx_user.h and with the CMake option: 793/793 build steps and zero warnings in each. GCC 14.3 host builds passed for the default, no-chain, and add-ons-disabled configurations. Assisted-by: Codex (GPT-6) <noreply@openai.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #475
Defining
NX_DISABLE_PACKET_CHAINinnx_user.hremoves packet-link fields, but CMake still compiled MQTT, WebSocket, RTP, and NetX Secure.CMake now detects the setting, disables fragmentation, and excludes components that require packet chaining. Applications can also select the configuration with
NXD_DISABLE_PACKET_CHAIN=ON, omit all add-ons, or omit NetX Secure. The no-chain regression builds use the same source selection.Cortex-M7 GNU 14.2.1/Ninja builds passed with the macro in
nx_user.hand with the CMake option: 793/793 build steps and zero warnings in each. GCC 14.3 host builds passed for the default, no-chain, and add-ons-disabled configurations. Not run on hardware.