Repository navigation
Ran the packet debug information test, which no build ever ran - #497
Merged
Merged
Conversation
netx_packet_debug_info_test is the only test of _nx_packet_debug_info_get, the routine an application calls to read the debug record of each packet in a pool. Its condition required __NETXDUO_MINOR_VERSION__ to be greater than 8, and NetX Duo's minor version is 5, so it reported N/A in every build, including those that enable NX_ENABLE_PACKET_DEBUG_INFO. The version term is removed and the test body is unchanged; it passes in each build with packet debug information and IPv4. Assisted-by: Claude Code (Opus 5.5) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
netx_packet_debug_info_testis the only test of_nx_packet_debug_info_get, the routine anapplication calls to read the debug record
NX_ENABLE_PACKET_DEBUG_INFOkeeps on each packet of apool. Its condition is
and
__NETXDUO_MINOR_VERSION__is 5 ondev, so the test reports N/A in every configuration,including the four that enable
NX_ENABLE_PACKET_DEBUG_INFO. No other file in the repositorycalls
_nx_packet_debug_info_get, so nothing tests it.Measured on
dev(3b3c8b30)Change
The version term is removed, and the file takes the AI-assistance line under its header. The
test body does not change.
Test
Swept over all 43 configurations of
test/cmake/netxduo, five runs each: 20 pass (the fourconfigurations above), 195 N/A, 0 fail, 0 build failures.