Fix( mqtt ) mqv filter operator precedence#1511
Open
jona42-ui wants to merge 1 commit intoeclipse-thingweb:masterfrom
Open
Fix( mqtt ) mqv filter operator precedence#1511jona42-ui wants to merge 1 commit intoeclipse-thingweb:masterfrom
jona42-ui wants to merge 1 commit intoeclipse-thingweb:masterfrom
Conversation
…llback The nullish coalescing operator (??) only triggers on null or undefined, not on empty strings. When the URL path is '/', pathname.slice(1) returns '' which is falsy but not null/undefined, causing mqv:filter and mqv:topic to be silently ignored. Fixes eclipse-thingweb#1508 Signed-off-by: jona42-ui <jonathanthembo123@gmail.com>
jona42-ui
force-pushed
the
fix/binding-mqtt-mqv-filter-operator-precedence
branch
from
7289e7f to
b6a6b9e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
use the logical OR operator (||) instead of nullish coalescing (??)
Fixes #1508