Skip to content

[2185] Fix ownership of constraints created inside requirement#2186

Merged
AxelRICHARD merged 1 commit intomainfrom
pcd/fix/create-constraint-in-requirement
May 5, 2026
Merged

[2185] Fix ownership of constraints created inside requirement#2186
AxelRICHARD merged 1 commit intomainfrom
pcd/fix/create-constraint-in-requirement

Conversation

@pcdavid
Copy link
Copy Markdown
Contributor

@pcdavid pcdavid commented May 4, 2026

Bug: #2185
Signed-off-by: Pierre-Charles David pierre-charles.david@obeo.fr

PLEASE READ ALL ITEMS AND CHECK ONLY RELEVANT CHECKBOXES BELOW

Auto review

  • Have you reviewed this PR? Please do a first quick review, It is very useful to detect typos and missing copyrights, check comments, check your code... The reviewer will thank you for that :)

Project management

  • Has the pull request been added to the relevant milestone?
  • Have the priority: and pr: labels been added to the pull request? (In case of doubt, start with the labels priority: low and pr: to review later)
  • Have the relevant issues been added to the pull request?
  • Have the relevant labels been added to the issues? (area:, type:)
  • Have the relevant issues been added to the same project milestone as the pull request?

Changelog and release notes

  • Has the CHANGELOG.adoc + doc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adoc been updated to reference the relevant issues?
  • Have the relevant API breaks been described in the CHANGELOG.adoc?
  • Are the new / upgraded dependencies mentioned in the relevant section of the CHANGELOG.adoc?
  • In case of a change with a visual impact, are there any screenshots in the doc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adoc?
  • In case of a key change, has the change been added to Key highlights section in doc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adoc?

Documentation

  • Have you included an update of the documentation in your pull request? Please ask yourself if an update (installation manual, user manual, developer manual...) is needed and add one accordingly.

Tests

  • Is the code properly tested? Any pull request (fix, enhancement or new feature) should come with a test (or several). It could be unit tests, integration tests or cypress tests depending on the context. Only doc and releng pull request do not need for tests.

// ConstraintUsage of a RequirementDefinition or RequirementUsage."
intermediateContainer = Optional.of(SysmlPackage.eINSTANCE.getRequirementConstraintMembership());
} else if (this.container instanceof Namespace) {
intermediateContainer = Optional.of(SysmlPackage.eINSTANCE.getOwningMembership());
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure about that. I think it should probably be an explicit call to caseFeature or just return null to let the switch continue its process and fallback to caseFeature.

Bug: #2185
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
@pcdavid pcdavid force-pushed the pcd/fix/create-constraint-in-requirement branch from a74ac8c to b0d4103 Compare May 5, 2026 07:45
@AxelRICHARD AxelRICHARD merged commit 0ac2d20 into main May 5, 2026
4 checks passed
@AxelRICHARD AxelRICHARD deleted the pcd/fix/create-constraint-in-requirement branch May 5, 2026 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

When creating a constraint inside a requirement, is should be owned through a RequirementConstraintMembership

2 participants