[2185] Fix ownership of constraints created inside requirement#2186
Merged
AxelRICHARD merged 1 commit intomainfrom May 5, 2026
Merged
[2185] Fix ownership of constraints created inside requirement#2186AxelRICHARD merged 1 commit intomainfrom
AxelRICHARD merged 1 commit intomainfrom
Conversation
98e1fe8 to
a74ac8c
Compare
AxelRICHARD
reviewed
May 4, 2026
| // ConstraintUsage of a RequirementDefinition or RequirementUsage." | ||
| intermediateContainer = Optional.of(SysmlPackage.eINSTANCE.getRequirementConstraintMembership()); | ||
| } else if (this.container instanceof Namespace) { | ||
| intermediateContainer = Optional.of(SysmlPackage.eINSTANCE.getOwningMembership()); |
Member
There was a problem hiding this comment.
I'm not sure about that. I think it should probably be an explicit call to caseFeature or just return null to let the switch continue its process and fallback to caseFeature.
Bug: #2185 Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
a74ac8c to
b0d4103
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug: #2185
Signed-off-by: Pierre-Charles David pierre-charles.david@obeo.fr
PLEASE READ ALL ITEMS AND CHECK ONLY RELEVANT CHECKBOXES BELOW
Auto review
Project management
priority:andpr:labels been added to the pull request? (In case of doubt, start with the labelspriority: lowandpr: to review later)area:,type:)Changelog and release notes
CHANGELOG.adoc+doc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adocbeen updated to reference the relevant issues?CHANGELOG.adoc?CHANGELOG.adoc?doc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adoc?Key highlightssection indoc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adoc?Documentation
Tests