fix(actions): generate unique tags for each action instance (#59) - #126
Open
MohamedRady-99 wants to merge 1 commit into
Open
fix(actions): generate unique tags for each action instance (#59)#126MohamedRady-99 wants to merge 1 commit into
MohamedRady-99 wants to merge 1 commit into
Conversation
MohamedRady-99
requested review from
PandaeDo,
qor-lb and
vinodreddy-g
as code owners
August 20, 2026 13:29
MohamedRady-99
requested a deployment
to
workflow-approval
August 20, 2026 13:29 — with
GitHub Actions
Waiting
MohamedRady-99
requested a deployment
to
workflow-approval
August 20, 2026 13:29 — with
GitHub Actions
Waiting
License Check Results🚀 The license check job ran with the Bazel command: bazel run --lockfile_mode=error //:license-checkStatus: Click to expand output |
|
The created documentation from the pull request is available at: docu-html |
MohamedRady-99
force-pushed
the
fix/action-ids-uniqueness
branch
from
August 20, 2026 13:39
8d56281 to
acffb68
Compare
MohamedRady-99
requested a deployment
to
workflow-approval
August 20, 2026 13:40 — with
GitHub Actions
Waiting
MohamedRady-99
requested a deployment
to
workflow-approval
August 20, 2026 13:40 — with
GitHub Actions
Waiting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notes for Reviewer
This PR resolves the issue where all actions of the same type (e.g., Sequence, Concurrency, Graph) share the same Tag ID when printing the program
representation #59.
Since every instance of a given action type initialized its ActionBaseMeta using a hardcoded static string (such as "orch::internal::sequence"), they
all computed the exact same Tag ID (via djb2 hash). This made different instances of the same action type indistinguishable in printed representations
and debugging logs.
Proposal:
Currently, actions share identical static tags. This PR updates the tag initialization logic as follows:
AtomicUsize counter to append a unique incrementing suffix to each action instance's tag.
IfElseArcMutex, Catch, Sync, Trigger) to use next_unique_action_tag.
Pre-Review Checklist for the PR Author
Checklist for the PR Reviewer
Post-review Checklist for the PR Author
References
Closes #59