-
Notifications
You must be signed in to change notification settings - Fork 28
Fix top-level documentation #259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
ab2a372
04373c0
a5f3bf5
9f04a79
2ddff51
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| ../../../../score/datarouter/doc/design/logging_architecture.md |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| ../../../../score/datarouter/doc/design/shm_apis.md |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -13,24 +13,24 @@ | |
| # ******************************************************************************* | ||
|
|
||
|
|
||
| Data Router Documentation | ||
| Datarouter | ||
| ========================= | ||
|
|
||
| This section is reserved for data router-specific documentation. | ||
|
|
||
| .. comp:: Data Router | ||
| :id: comp__data_router | ||
| .. comp:: Datarouter | ||
| :id: comp__datarouter | ||
| :security: YES | ||
| :safety: ASIL_B | ||
| :safety: QM | ||
| :status: valid | ||
| :implements: logic_arc_int__logging__logging | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. comp__datarouter don't implement logic_arc_int__logging__logging.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. not sure what you mean. logic_arc_int__logging__logging is the logical interface all these components implement for the feature feat__logging |
||
| :belongs_to: feat__logging | ||
|
|
||
| This is the datarouter component responsible for routing log messages to remote Diagnostics Log and Trace (DLT) backend. | ||
| Datarouter is the DLT (Diagnostic log and trace) daemon executable. It reads records from source shared-memory ring buffers, manages source | ||
| sessions, routes messages to configured channels via UDP multicast, and reports source statistics and message drops. | ||
|
|
||
| .. toctree:: | ||
| :titlesonly: | ||
| :maxdepth: 1 | ||
| :glob: | ||
|
|
||
| * | ||
| requirements/index | ||
| detailed_design/logging_architecture | ||
| detailed_design/shm_apis | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The file shall be included as reference to detailed design or there should be folder on the rendered website design decisions
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. fixed |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| ../../../../../score/mw/log/design/backend/datarouter_backend/README.md |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| ../../../../score/mw/log/design/backend/file_output_backend.md |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| mw::log backend Detailed Design | ||
| =============================== | ||
|
|
||
| The backend composition and recorder relationships are shown below: | ||
|
|
||
| .. uml:: ../../../../score/mw/log/design/backend/mw_log_recorders.puml | ||
|
|
||
| .. toctree:: | ||
| :maxdepth: 1 | ||
|
|
||
| file_output_backend | ||
| datarouter_backend/README |
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The template https://github.com/eclipse-score/module_template/blob/main/score/component_example/docs/index.rst is not applied
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. done |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -13,11 +13,9 @@ | |
| # ******************************************************************************* | ||
|
|
||
|
|
||
| Logging Documentation | ||
| mw::log | ||
| ===================== | ||
|
|
||
| This section is reserved for middleware-specific documentation. | ||
|
|
||
| .. comp:: Logging Component | ||
| :id: comp__mw_logging | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Should mw_looging be the final component name? I thought we wanted to use log_backend in the logging repo and 'log' in the baselibs repo.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. No. baselibs will have one dependable_element in which mw::log will be part of.
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. That means we will have three components in the logging feature
right ? In the safety artifacts we working with references . That means the safety artifact for log (baseline) includes only an reference to mw_log (logging) |
||
| :security: YES | ||
|
|
@@ -26,11 +24,18 @@ This section is reserved for middleware-specific documentation. | |
| :implements: logic_arc_int__logging__logging | ||
| :belongs_to: feat__logging | ||
|
|
||
| This is the logging component library responsible for selecting the appropriate log sinks based on configuration at runtime. It can perform tasks such as log formatting, filtering, and composite backend selection based on runtime context and configuration. The logging component is designed to be extensible, allowing for custom logging backend to be added as needed. | ||
| This is the logging middleware library responsible for providing conrete backends for the supported recorder | ||
| implementations. The logging component is designed to be extensible, allowing supported as well as custom logging | ||
| backend to be added as needed. | ||
|
|
||
| The ``mw::log`` implementation spans the ``score_baselibs`` (frontend) and ``score_logging`` (backend) | ||
| repositories; see the :doc:`feature architecture </features/architecture/index>` for the repository boundary | ||
| and cross-repository contract. | ||
|
|
||
| .. toctree:: | ||
| :titlesonly: | ||
| :maxdepth: 1 | ||
| :glob: | ||
|
|
||
| * | ||
| requirements/index | ||
| detailed_design/index | ||
| design_decisions/explicit_init | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. file shall be moved to ./mw_log/requirements/
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. done |
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Shall we add a folder _assets for that ?
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. done |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,63 @@ | ||
| @startuml mw_log_architecture | ||
| title mw::log (ASIL B): repository boundary | ||
|
|
||
| skinparam componentStyle rectangle | ||
| skinparam packageStyle rectangle | ||
| skinparam linetype ortho | ||
|
|
||
| package "score_baselibs" as Baselibs #LightYellow { | ||
| component "mw::log Frontend API\n(logger, log_stream, runtime)" as Frontend | ||
| component "Console Backend\n(static, built-in)" as Console | ||
| component "score_log Rust Facade\n(score_log, score_log_fmt,\nscore_log_fmt_macro)" as RustFacade | ||
| artifact "Frontend safety plan\n+ AoU forwarding (Usage Contract)" as FrontendPlan #line.dashed | ||
|
|
||
| Frontend -down-> Console : static composition (baseline) | ||
| Frontend .. FrontendPlan | ||
| } | ||
|
|
||
| package "score_logging" as Logging #LightBlue { | ||
| component "mw::log Concrete Recorders\n(file, remote/DLT, slog)" as Recorders | ||
| component "Backend Integration\ntargets (file, remote/datarouter, ...)" as Integration | ||
| component "Rust Log Bridge\n(score_log_bridge + adapter.cpp)" as RustBridge | ||
| component "Rust Bridge C++ Init API\n(score_log_bridge_cpp_init)" as RustCppInit | ||
| artifact "Backend safety plan\n+ AoU forwarding (Integration Contract)" as BackendPlan #line.dashed | ||
|
|
||
| Recorders -down-> Integration : static registration | ||
| Recorders .. BackendPlan | ||
| } | ||
|
|
||
| Recorders .up.> Frontend : implements Recorder interface\n(static registration via backend_table, baseline) | ||
|
|
||
| RustBridge -up-> RustFacade : implements score_log\nlogger backend | ||
| RustBridge -right-> Frontend : adapter.cpp calls\nRuntime::GetRecorder() (FFI) | ||
| RustBridge .up.> Recorders : direct static link\n(score/issues/2848) | ||
| RustCppInit -down-> RustBridge : set_default_logger (FFI)\nconfigures default logger | ||
|
|
||
| package "Optional Future Evolution" as Future #WhiteSmoke { | ||
| component "Runtime Plugin Loading\n(dlopen-based)" as Runtime | ||
| } | ||
|
|
||
| Runtime .[#gray]right.> Frontend : experimental only | ||
|
|
||
| note bottom of Future | ||
| Not an assumed production | ||
| commitment; decision-gated. | ||
| end note | ||
|
|
||
| note as N1 | ||
| Each repo owns its own phase gates, | ||
| safety plan, and governance; the only | ||
| cross-repo contract is the Recorder | ||
| interface + static backend_table | ||
| registration (plugin_api.h is an | ||
| existing C ABI seam, not used | ||
| for static composition). The Rust | ||
| bridge reaches the Frontend/Recorders | ||
| the same way, via direct static | ||
| linkage rather than backend_table. | ||
| end note | ||
|
|
||
| Baselibs -[hidden]down-> N1 | ||
| Logging -[hidden]down-> N1 | ||
|
|
||
| @enduml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
template shall be used https://github.com/eclipse-score/module_template/blob/main/score/component_example/docs/index.rst
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done