Fix sandbox test failure on some machines - #470
Conversation
License Check Results🚀 The license check job ran with the Bazel command: bazel run --lockfile_mode=error //:license-checkStatus: Click to expand output |
|
The created documentation from the pull request is available at: docu-html |
TimoSteuerwaldETAS
left a comment
There was a problem hiding this comment.
Looks good and test still works on my environment. So all fine! 😃👍
|
|
||
|
|
||
| @pytest.fixture(autouse=True) | ||
| def require_realtime_scheduling(target): |
There was a problem hiding this comment.
Would it make sense to just use something like this
IS_CI = os.getenv("CI") == "true"
@pytest.mark.skipif(
not IS_CI and not can_set_up_env(),
reason="Host cannot set up required dependency",
)so that this skips for local users, then the CI env var should be set on CI so there it would fail their.
There was a problem hiding this comment.
I think if the test is just skipped in Python, Bazel will still say it passed. So it would need to be skipped at a higher level.
There was a problem hiding this comment.
I made it so the test fails because I thought skipping has the danger that due to some bug the test may end up being skipped which might go unnoticed for some time. Especially, due to all the _qemu tests being skipped
//tests/integration/sandbox_options:sandbox_options fails on some machines when run in docker based on whether the underlying linux kernel was built with CONFIG_RT_GROUP_SCHED or not.
The PR introduces the following behavior: