fix: avoid duplicate needs from nested docs bundles - #758
Merged
MaximilianSoerenPollak merged 4 commits intoAug 26, 2026
Merged
Conversation
AlexanderLanin
requested review from
MaximilianSoerenPollak,
a-zw,
dcalavrezo-qorix and
nradakovic
as code owners
August 25, 2026 17:16
Contributor
License Check Results🚀 The license check job ran with the Bazel command: bazel run --lockfile_mode=error //src:license-checkStatus: Click to expand output |
Contributor
|
Documentation preview for this pull request is available at: |
MaximilianSoerenPollak
previously approved these changes
Aug 26, 2026
MaximilianSoerenPollak
left a comment
Contributor
There was a problem hiding this comment.
Looked through in a call. Looks alright 💯
Signed-off-by: Alexander Lanin <Alexander.Lanin@etas.com>
MaximilianSoerenPollak
approved these changes
Aug 26, 2026
MaximilianSoerenPollak
left a comment
Contributor
There was a problem hiding this comment.
Talked about in a call. Looks good 💯
MaximilianSoerenPollak
merged commit Aug 26, 2026
d0cffbc
into
eclipse-score:main
16 of 17 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bug
When a docs() target included a docs_bundle from a subdirectory, the complete transitive bundle DefaultInfo was passed as Sphinx srcs. Nested sources were then processed once as raw sources and once through score_mounts, causing needs.duplicate_id failures when the docs bundle was consumed by another docs() target.
Required for eclipse-score/score#3215
Validation
Note: the existing data_files_runfiles runtime smoke test can encounter workspace-wide test-log warnings in a dirty workspace; its needs_json build passes.