docs: improve metamodel reference - #748
Conversation
License Check Results🚀 The license check job ran with the Bazel command: bazel run --lockfile_mode=error //src:license-checkStatus: Click to expand output |
|
Documentation preview for this pull request is available at: |
a-zw
left a comment
There was a problem hiding this comment.
To be honest, I hate this. It is too much waste. Personally, I will rather look at the YAML file again.
MaximilianSoerenPollak
left a comment
There was a problem hiding this comment.
From my side this is okay.
Though it seems to get more and more unmaintainable with updates so we should ensure that it's not such a mess in the end that we don't understand it anymore.
I would also wait for @a-zw to be alright with this being merged as he had comments regarding it.
0046221
There was a problem hiding this comment.
Pull request overview
Refactors and expands the generated metamodel reference.
Changes:
- Introduces typed models and dedicated Mermaid/RST renderers.
- Adds per-type diagrams and collapsible option/link tables.
- Updates the generated-documentation reference link.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
generate_metamodel_rst.py |
Refactors and expands reference generation. |
BUILD |
Reformats generated outputs. |
generated_docs.rst |
Updates the metamodel reference link. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
Fixed in the pending worktree changes: Mermaid SVGs no longer use fixed 167/333px heights; they use automatic height so rendered text is not clipped. The changes remain intentionally uncommitted. |
|
Korrektur zum vorherigen Kommentar: Die automatische SVG-Höhe wurde auf Wunsch zurückgenommen und die ursprüngliche feste Höhenlogik (167/333 px bzw. Standardhöhe) wiederhergestellt. Der Screenshot-Befund bleibt damit bewusst offen. |
990935f
into
eclipse-score:main


Review 1: is it readable etc? see rendered page
Review 2: should we make the code more readable via OOP?