feat: install pre-commit from shared catalog - #144
Merged
Conversation
Member
Author
|
AI review completed with no major findings. Independent full-PR reviews of PRs #143 and #144 were performed by:
The reviews focused on correctness, regressions, semantics, architecture, security, compatibility, and other merge-blocking issues. Minor/nit-level findings were intentionally ignored. |
lurtz
approved these changes
Aug 14, 2026
Replace the standalone DevContainer feature with the catalogued pre-commit package installed by pinned uv. Keep the repository container and published feature aligned with the Bazel target. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Use the catalogued uvx runner for REUSE commands and remove the feature installer assumption that PIPX_BIN_DIR was written by another DevContainer feature. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
AlexanderLanin
force-pushed
the
pre-commit-devcontainer
branch
from
August 14, 2026 11:24
6f11581 to
85ccee3
Compare
etas-contrib-automation Bot
pushed a commit
to etas-contrib/score_devcontainer
that referenced
this pull request
Aug 14, 2026
## Summary - add a shared catalog for pinned Python command-line tools - expose Python tools through Bazel using the pinned `uvx` binary and a shell launcher - add pinned `uv tool install` support for DevContainer feature installers - document and test the catalog, working-directory, runfiles, and version contracts ## Rationale Python distributions need different delivery mechanics from native release binaries. The shared catalog keeps package versions aligned while Bazel executes tools on demand without requiring host Python. ## Scope This is the foundation layer of stack #145. The existing DevContainer installation remains unchanged here; PR eclipse-score#144 adopts this catalog for `pre-commit`. ## Validation - full pre-commit suite through `//tools:pre-commit` - `//tools:python_tool_runner_test` - external-module smoke tests with Bazel 8 and Bazel 9 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Aug 14, 2026
|
🎉 This PR is included in version 1.11.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pre-commit4.5.1 from the shared Python tool catalog with pinneduvuvxrunnerRationale
The DevContainer PATH and Bazel target now consume one package pin while retaining delivery mechanisms suited to their environments. The REUSE workflow uses uvx directly and no longer relies on environment setup from another feature.
Scope
This is the DevContainer integration layer of stack #145 and depends on PR #143. It contains the container wiring and the directly coupled migration of existing pipx-based REUSE commands.
Validation
uv tool installusing the catalogued packagescripts/test.shDevContainer build and feature test