Enable linux-sandbox for coverage - #207
Merged
Merged
Conversation
pawelrutkaq
requested review from
AlexanderLanin,
MaximilianSoerenPollak,
PiotrKorkus,
dcalavrezo-qorix,
lurtz,
nradakovic and
opajonk
as code owners
August 17, 2026 16:41
lurtz
reviewed
Aug 17, 2026
lurtz
left a comment
lurtz
left a comment
Contributor
There was a problem hiding this comment.
I would have not made it configurable. Does enabling linux-sandbox do any harm?
Contributor
Author
|
Since it touches Apparmor, i made it configurable. However, afaik, actions scopes the AppArmor settings precisely, so we may flip the configuration option simply to default:true |
Contributor
|
A few months ago I enabled linux-sandbox for QNX: There I did it unconditionally, because I considered an option as too much complexity. That was accepted without concerns. And so far nobody has complained. Therefore I think, it does not need to be configurable. But if we, it has to be done consistently. |
Contributor
Author
|
done |
Needed in case the tests are using some common locations like /tmp for testing to not collide
pawelrutkaq
force-pushed
the
pawelrutkaq_enable_linux_sandbox_for_coverage
branch
from
August 18, 2026 13:57
7708d2c to
1e7fdbf
Compare
lurtz
approved these changes
Aug 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needed in case the tests are using some common locations like /tmp for testing to not collide