Bug fix for output exec path - #121
Merged
Merged
Conversation
The template was missing expand_if_available which by default sets output execution path. The variable can be set over different toolchain so we always need to check if the variable is set regardless if our actions need it or not.
nradakovic
requested review from
AlexanderLanin,
antonkri and
dcalavrezo-qorix
as code owners
August 20, 2026 09:52
nradakovic
added
bug
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Linux and QNX C++ toolchain config templates to guard expansion of the %{output_execpath} build variable when emitting archiver (ar) output flags, aligning the archiver behavior with the existing guarded use of output_execpath in link output flags.
Changes:
- Add
expand_if_available = "output_execpath"to thearchiver_flagsfeature’s output flag group forACTION_NAMES.cpp_link_static_library(Linux + QNX). - Keep formatting consistent with other
flag_group(...)blocks that already useexpand_if_available.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| templates/qnx/cc_toolchain_config.bzl.template | Guard %{output_execpath} expansion for static library archiving output flags. |
| templates/linux/cc_toolchain_config.bzl.template | Guard %{output_execpath} expansion for static library archiving output flags. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
antonkri
approved these changes
Aug 20, 2026
github-project-automation
Bot
moved this from In Progress
to Done
in INF - Infrastructure Community
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The template was missing expand_if_available which by default sets output execution path. The variable can be set over different toolchain so we always need to check if the variable is set regardless if our actions need it or not.