Revert "Extract common toolchain features (#85) (#113)"

[nradakovic]

This reverts commit 75330be.

[Copilot]

Pull request overview

Reverts commit 75330be32473069cff3881a1f79ad8ee156e9c6f, undoing the “Extract common toolchain features” refactor by removing the shared-features template and re-inlining those feature definitions into the Linux and QNX GCC toolchain config templates.

Changes:

• Inline previously shared toolchain feature definitions back into templates/linux and templates/qnx cc toolchain config templates.
• Remove generation/wiring of the shared-features template from the GCC repository rule and module extension.
• Update tests/MODULE.bazel.lock to drop the now-removed cc_toolchain_shared_features attribute and reflect updated digests.

Reviewed changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
tests/MODULE.bazel.lock	Updates recorded module extension/toolchain attributes and digest after reverting shared-features extraction.
templates/qnx/cc_toolchain_config.bzl.template	Re-inlines shared feature/action lists and feature definitions directly into the QNX toolchain config template.
templates/linux/cc_toolchain_config.bzl.template	Re-inlines shared feature/action lists and feature definitions directly into the Linux toolchain config template.
templates/cc_toolchain_shared_features.bzl.template	Removes the shared-features template introduced by the reverted commit.
rules/gcc.bzl	Stops templating shared_features.bzl and removes the repository_rule attribute for the shared-features template.
extensions/gcc.bzl	Stops propagating cc_toolchain_shared_features in toolchain dictionaries and when instantiating gcc_toolchain.

Suppressed comments (1)

templates/linux/cc_toolchain_config.bzl.template:1079

• This blank line contains trailing whitespace. Removing it avoids noise in diffs and helps keep generated templates stable across editors/formatters.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.