feat: add first-interaction workflow for new contributors - #42
HosurSharanamma wants to merge 6 commits into
Conversation
7e54798 to
c872e62
Compare
alexmohr
left a comment
There was a problem hiding this comment.
Thank for your pull request :)
| @@ -0,0 +1,45 @@ | |||
| # SPDX-License-Identifier: Apache-2.0 | |||
| # SPDX-FileCopyrightText: 2025 The Contributors to Eclipse OpenSOVD (see CONTRIBUTORS) | |||
There was a problem hiding this comment.
Please use 2026.
The trailing (see CONTRIBUTORS) is not common, I have not seen it in SCORE either. @alexmohr what was the intend of this remark and file. Could we simply remove it, at least he appearance in the comment.
There was a problem hiding this comment.
Right now it is necessary to keep (see CONTRIBUTORS) otherwise the pipeline complains that the copyright header does not match. Year can be adjusted.
I'm not sure why we're using the copyright header with CONTRIBUTORS iirc @floroks was deeper involved in the discussion.
There was a problem hiding this comment.
I'll clarify with the compliance people if this is necessary for some legal reasons, I'll report back
There was a problem hiding this comment.
So feedback from our MBTI compliance people is pretty much what @lh-sag suggested :)
We can drop the (see Contributors) but keeping the block about notice etc (which no one discussed to remove here, just mentioning it for clarity) should be kept, because an Apache 2.0 licensed software must be shipped with a notice file if one is contained and mentioning it in the copyright makes it harder to miss the notice file (in theory at least).
Imho would make sense to do this in a follow up though.
There was a problem hiding this comment.
#56 <-- follow up to fix this, as this is out of scope here.
| - Make sure CI checks pass before requesting a review. | ||
| - Eclipse projects require a **DCO sign-off** on every commit: | ||
| use `git commit -s` or add `Signed-off-by: Your Name <email>` manually. | ||
| - See [CONTRIBUTING.md](https://github.com/eclipse-opensovd/opensovd/blob/main/CONTRIBUTING.md) for details. |
There was a problem hiding this comment.
Is there a way to point to the repositories CONTRIBUTING.md file?
Usually the projects have some specifics.
There was a problem hiding this comment.
do they? In CDA we're missing the file entirely, but that could be an oversight on our end too 🙈
There was a problem hiding this comment.
Maybe we can make the url overwritable then. If not specified pick the generic one as a fallback.
At least to me it would be odd getting such comment pointing to opensovd but I want the contribution guide from opensovd-cda/-core
There was a problem hiding this comment.
probably would be best if each project just ships the file, if it's a carbon copy so be it, but it's also easier for newcomers to find it then. I'll make sure to fix this on cda side.
f06fdd6 to
4c0fb8c
Compare
4c0fb8c to
95a029e
Compare
7d15c78 to
4db558c
Compare
| # pull-requests: write is required when post-pr-comment input is true. | ||
| # The caller workflow must grant this permission explicitly. | ||
| pull-requests: write | ||
| # The caller workflow must grant this permission explicitly. |
There was a problem hiding this comment.
todo: please fix the indentation here.
| # The caller workflow must grant this permission explicitly. | |
| # The caller workflow must grant this permission explicitly. |
There was a problem hiding this comment.
@HosurSharanamma please do not resolve my review comments. I will resolve them myself when I re-reviewed. This one was resolved, but is not fixed yet. The indentation is still wrong.
| if: >- | ||
| inputs.post-pr-comment && github.event_name == 'pull_request' && github.event.pull_request.head.repo.full_name == github.repository | ||
| uses: actions/github-script@v9 | ||
| if: ${{ inputs.post-pr-comment && github.event_name == 'pull_request' }} |
There was a problem hiding this comment.
question: these changes seem unrelated to the 'first interaction workflow' are these on purpose?
There was a problem hiding this comment.
Thanks for hinting , those changes to coverage.yml were unrelate. I've removed them in the latest push.
There was a problem hiding this comment.
I still see the changes in the diff, github fooling me or does this still need a push?
96d7b33 to
4db558c
Compare
| issue-message: | | ||
| Welcome, and thanks for opening your first issue! | ||
|
|
||
| Please make sure you've reviewed our [contribution guidelines](https://github.com/eclipse-opensovd/opensovd/blob/main/CONTRIBUTING.md) |
There was a problem hiding this comment.
| Please make sure you've reviewed our [contribution guidelines](https://github.com/eclipse-opensovd/opensovd/blob/main/CONTRIBUTING.md) | |
| Please make sure you've reviewed our [contribution guidelines](https://github.com/{{ github.repository_owner }}/${{ github.event.repository.name }}/blob/main/CONTRIBUTING.md) |
@alexmohr would this work for you? Given that you add this file to cda.
@HosurSharanamma I am not sure whether this works. So feel free to experiment.
There was a problem hiding this comment.
If that works that would be awesome.
Signed-off-by: sharanamma hosur <h.sharanamma@gmail.com>
Signed-off-by: sharanamma hosur <h.sharanamma@gmail.com>
Signed-off-by: HosurSharanamma <h.sharanamma@gmail.com>
Signed-off-by: HosurSharanamma <h.sharanamma@gmail.com>
718422d to
868a998
Compare
| # pull-requests: write is required when post-pr-comment input is true. | ||
| # The caller workflow must grant this permission explicitly. | ||
| pull-requests: write | ||
| # The caller workflow must grant this permission explicitly. |
There was a problem hiding this comment.
@HosurSharanamma please do not resolve my review comments. I will resolve them myself when I re-reviewed. This one was resolved, but is not fixed yet. The indentation is still wrong.
| if: >- | ||
| inputs.post-pr-comment && github.event_name == 'pull_request' && github.event.pull_request.head.repo.full_name == github.repository | ||
| uses: actions/github-script@v9 | ||
| if: ${{ inputs.post-pr-comment && github.event_name == 'pull_request' }} |
There was a problem hiding this comment.
I still see the changes in the diff, github fooling me or does this still need a push?
coverage.yml was accidentally carrying stale/reverted content (missing pull-requests: write permission, older github-script version, bad comment indentation) unrelated to the first-interaction workflow. Restore it to match main exactly.
Apply the same dynamic link pattern already used in the issue-message to the pr-message, so forks/other orgs point to their own CONTRIBUTING.md instead of eclipse-opensovd/opensovd.
|
coverage.yml is reverted back to match main exactly — the unrelated/stale content (missing pull-requests: write, wrong indentation, older github-script version) is gone. This PR now only touches first-interaction.yml. |
Summary
Adds a
first-interaction.ymlworkflow that automatically posts awelcome comment when someone opens their first issue or pull request
in the repository.
Motivation
Identified as a gap in issue #38 (CI parity analysis: opensovd-core
vs cicd-workflows). The
opensovd-corerepository already has thisworkflow; this change brings
cicd-workflowsto parity.Changes
.github/workflows/first-interaction.ymlusingactions/first-interaction@v1follow the contribution guidelines
CI checks and the Eclipse DCO sign-off requirement
Testing
uv run https://raw.githubusercontent.com/eclipse-opensovd/cicd-workflows/main/run_checks.pylocally — all checks passedcheck yamlandyamlfmthooksRelates to #38