Fix UI stall when using refresh button in Docker Explorer View - #630
Merged
Merged
Conversation
jjohnstn
commented
Sep 22, 2026
jjohnstn
commented
Contributor
- add new getConnectionsNow() method to DockerConnectionManager which gets the current connections and doesn't check or wait upon the refresh connections thread
- have RefreshCommandHandler use the new getConnectionsNow() method to get the current connections as we are running in the UI thread and if the refresh job hasn't yet returned, there are no valid connections to refresh
- fixes UI freeze 20+s: DockerConnectionManager.getConnections() blocks the UI thread (Thread.join without timeout) in RefreshCommandHandler #628
- add new getConnectionsNow() method to DockerConnectionManager which gets the current connections and doesn't check or wait upon the refresh connections thread - have RefreshCommandHandler use the new getConnectionsNow() method to get the current connections as we are running in the UI thread and if the refresh job hasn't yet returned, there are no valid connections to refresh - fixes eclipse-linuxtools#628
Contributor
Author
|
Ignoring problems with running call-license check. This PR added no new dependencies. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.