Repository navigation
Refactor SQL access through RelationalContext and extend the olap aggregators - #198
Merged
Merged
Conversation
…regators Refactoring without a change in behaviour: the relational engine follows SQL access into RelationalContext and keeps only the SQL rendering of the standard aggregators, whose evaluation now lives in olap. The data source, the dialect and the SQL guard come from the RelationalContext; RolapCell is a RelationalCell. The standard aggregators extend the olap ones and keep only their SQL rendering. The test run resolves without the configuration admin service. Signed-off-by: Stefan Bischof <stbischof@bipolis.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactoring without a change in behaviour: the relational engine follows SQL access into
RelationalContextandkeeps only the SQL rendering of the standard aggregators, whose evaluation lives in olap.
RelationalContext;RolapCellis aRelationalCell.