Repaint the plot area when chart overlays change - #3165
Merged
eselmeister merged 3 commits intoSep 25, 2026
Merged
Conversation
SWTChart doesn't repaint the chart on every mouse move anymore, it does so only while an axis position marker is drawn. The point modus of the time ranges chart just handed the points to the marker and relied on that repaint, so an added point isn't shown and cleared points stay drawn as soon as the position marker of the minutes axis is switched off or that axis is hidden. Request the repaint of the plot area the marker draws on when the points are updated. Use the SWTChart helpers for it, also where the hovered time range and the PCA selection request it. Assisted-by: Anthropic Claude Code (claude-opus-5-5[1m])
SWTChart doesn't repaint the chart on every mouse move anymore, it does so only while an axis position marker is drawn. The peak detector reset its box and baseline selection without a repaint, so a box selection cancelled by a double click stays drawn. The peak split didn't repaint after the first point of a tangent skim was set, so its marker isn't shown until the second point is set. Request the repaint when the markers are updated. Assisted-by: Anthropic Claude Code (claude-opus-5-5[1m])
SWTChart doesn't repaint the chart on every mouse move anymore, it does so only while an axis position marker is drawn. The PCA plots reset the Ctrl+drag selection on mouse up, but the plot area is only repainted if some samples or variables are highlighted, so a selection of nothing stays drawn. Request the repaint of the plot area the selection is drawn on. Assisted-by: Anthropic Claude Code (claude-opus-5-5[1m])
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SWTChart doesn't repaint the chart on every mouse move anymore, only while an axis position marker is drawn. These overlays relied on that repaint, so they didn't update as soon as the minutes axis marker is switched off or the axis is hidden, and never on charts without one:
Request the repaint where they change, using the helpers from eclipse-swtchart/swtchart#622, also for the hovered time range and the PCA selection drag.
Requires eclipse-swtchart/swtchart#622.
Assisted-by: Anthropic Claude Code (claude-opus-5-5[1m])