Dispose all cell editors of the PCA samples table - #3164
Merged
eselmeister merged 1 commit intoSep 25, 2026
Merged
eselmeister merged 1 commit into
eselmeister merged 1 commit into
Conversation
Contributor
Author
|
Fixes disposal problems in the log: |
SamplesListUI created one SamplesEditingSupport per editable column but kept only the last one, so the ColorCellEditor and its preview image were never disposed. The dispose() override in AnalysisEditorUI that was meant to clean up is not called when the part closes and also skipped super.dispose(). Keep all editing supports and dispose them when the table is disposed. Assisted-by: Anthropic Claude Code (claude-opus-5-5[1m])
akurtakov
force-pushed
the
pca-color-cell-editor-dispose
branch
from
September 25, 2026 06:37
7ea6387 to
84629e1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SamplesListUI created one SamplesEditingSupport per editable column but kept only the last one, so the ColorCellEditor and its preview image were never disposed. The dispose() override in AnalysisEditorUI that was meant to clean up is not called when the part closes and also skipped super.dispose().
Keep all editing supports and dispose them when the table is disposed.
Assisted-by: Anthropic Claude Code (claude-opus-5-5[1m])