Skip to content

Build E2E tests using nodejs 22.x - #23967

Merged
dmytro-ndp merged 1 commit into
mainfrom
CRW-13364
Sep 25, 2026
Merged

dmytro-ndp merged 1 commit into
mainfrom
CRW-13364

Conversation

@dmytro-ndp

@dmytro-ndp dmytro-ndp commented Sep 25, 2026 •

Copy link
Copy Markdown
Contributor

What does this PR do?

Updates E2E test build to use NodeJS 22.x.

Screenshot/screencast of this PR

What issues does this PR fix or reference?

https://redhat.atlassian.net/browse/CRW-13364

How to test this PR?

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

Summary by CodeRabbit

  • Chores
    • Updated the project’s checks, publishing workflow, and end-to-end build environment to use Node.js 22.

--
Assisted-by Claude Code

Signed-off-by: Dmytro Nochevnov <dnochevn@redhat.com>
@coderabbitai

coderabbitai Bot commented Sep 25, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 7fbfbdcd-a885-412a-922c-497726a913e1

📥 Commits

Reviewing files that changed from the base of the PR and between 78c71b1 and 9850909.

📒 Files selected for processing (3)
  • .github/workflows/pr-check.yml
  • .github/workflows/typescript-publish.yml
  • tests/e2e/build/dockerfiles/Dockerfile

Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review.


📝 Walkthrough

Walkthrough

Two GitHub Actions workflows and the end-to-end Docker build now select Node.js 22 instead of earlier Node.js versions. The publishing workflow’s later Node.js 24 step remains unchanged.

Changes

Node.js 22 runtime updates

Layer / File(s) Summary
Update Node.js runtime selections
.github/workflows/pr-check.yml, .github/workflows/typescript-publish.yml, tests/e2e/build/dockerfiles/Dockerfile
The PR check workflow changes from Node.js 18 to 22. The publishing workflow’s primary setup step changes from Node.js 16 to 22. The Docker build changes its NodeSource setup script from 18.x to 22.x.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to 98509

The CI workflows and the end-to-end test image now build with Node.js 22. No blocking issues were found, and the change is ready to merge after normal CI passes.

Architecture Summary

Architecture risk: 🔵 Low · up to 98509

The change affects 1 system.

Changed systems: tests

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

  • observed — tests (service) was modified; 1 changed file maps to changed impact.

Before / after behavior

  • observed — Modified behavior in tests/e2e/build/dockerfiles/Dockerfile: The NodeSource setup script changes from 18.x to 22.x.
  • observed — Modified behavior in .github/workflows/pr-check.yml: The setup-node step now selects Node.js 22 instead of Node.js 18.
  • observed — Modified behavior in .github/workflows/typescript-publish.yml: The primary Node.js setup step now uses Node.js 22 instead of Node.js 16.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: updating E2E test builds to use Node.js 22.x.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@dmytro-ndp
dmytro-ndp merged commit 677aa96 into main Sep 25, 2026
7 checks passed
@dmytro-ndp
dmytro-ndp deleted the CRW-13364 branch September 25, 2026 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants