Conversation
Signed-off-by: ixcans <78341771+ixcans@users.noreply.github.com>
Signed-off-by: ixcans <78341771+ixcans@users.noreply.github.com>
Signed-off-by: ixcans <78341771+ixcans@users.noreply.github.com>
Signed-off-by: ixcans <78341771+ixcans@users.noreply.github.com>
Move to the stable RustCrypto releases: ed25519-dalek 3, p256 0.14, rand 0.10 and rand_core 0.10. - RngCore is now Rng, and generic RNG parameters are ?Sized. - OsRng is replaced by rand::rng(). - p256: SigningKey::generate_from_rng, SEC1 point encoding renamed, from_bytes takes a fixed-size array, and the direct ecdsa and elliptic-curve dependencies are dropped in favour of p256's re-exports. Originally proposed in eclipse-biscuit#312; ported onto the current crypto traits layout. Signed-off-by: ixcans <78341771+ixcans@users.noreply.github.com>
prost-build no longer bundles protoc, so the test that regenerates the protobuf bindings and compares them with the committed schema.rs needs a protoc binary on the runner. Signed-off-by: ixcans <78341771+ixcans@users.noreply.github.com>
The signature crate no longer includes the underlying cause in the InvalidSignature message, so regenerate the samples. Signed-off-by: ixcans <78341771+ixcans@users.noreply.github.com>
Signed-off-by: ixcans <78341771+ixcans@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rebases #330 onto current
mainand stacks #312 on top, ported to the currentcrypto traits layout. Original commits and authorship are preserved
(@avandecreme for #330, @baloo for #312).
What changes
base640.22,prost/prost-types/prost-build0.14,nom8,thiserror2, removal of outdated non-direct dependencies, andsyn2 forbiscuit-quote(kept thefull/extra-traitsfeatures, andmanyhow, whichmainuses now).ed25519-dalek3,p2560.14,rand0.10,rand_core0.10.RngCorebecomesRng, RNG parameters are?Sized,OsRngbecomesrand::rng(), and the directecdsa/elliptic-curvedependencies are droppedin favour of
p256's re-exports. Ported onto thePrivateKey/Sign/Verifytrait layout thatmainhas now.Things the dependency bumps required
prost-build0.11+ no longer bundlesprotoc, so theformat::tests::prototest needs it on the runner: the
buildandcapijobs now installprotobuf-compiler.schema.rsregenerated withprost-build0.14 (formatting,Eq, Hashderives). No schema change.
biscuit-auth/samples/samples.json: thesignaturecrate no longer appends"Verification equation was not satisfied" to
InvalidSignature, so thatmessage text in four samples changed. No change to tokens or verdicts.
Breaking
rand_core/randare part ofbiscuit-auth's public API(
new_with_rng,build_with_rng), so this is a breaking change, as noted in#312.
Testing
All three workflows (build, capi, coverage) green on a fork run of this exact
stack, including
cargo test --features="serde-error,bwk", the trybuilderror-message tests, and the sample regeneration check (
git diff --exit-code).