tests: use an explicit 10 s run limit in the remaining default-limit … - #348
Merged
Merged
Conversation
…tests
`AuthorizerLimits::default()` sets `max_time` to 1 ms. Most tests that
run Datalog already override it with 10 s ("cheap worker on GitHub
Actions"), but five call sites still relied on the default:
- token::authorizer::tests::query_authorizer_from_token_tuple
- token::authorizer::tests::query_authorizer_from_token_string
- token::authorizer::tests::rule_validate_variables
- token::tests::basic (3-block token)
- token::tests::authorizer_queries (query on the cloned authorizer)
Under cargo-tarpaulin (ptrace, unoptimised build) `rule_validate_variables`
fails deterministically with `RunLimit(Timeout)`, and the others are
one slow runner away from the same. This is what keeps the Coverage job
red once the biscuit-quote timeout is out of the way.
Switch them to `authorize_with_limits` / `query_with_limits` with the
same 10 s budget the neighbouring tests use. Verified with three
consecutive `cargo tarpaulin --workspace --exclude biscuit-quote` runs
(89/89 lib tests pass); the same command on main fails.
divarvel
approved these changes
Sep 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…tests
AuthorizerLimits::default()setsmax_timeto 1 ms. Most tests that run Datalog already override it with 10 s ("cheap worker on GitHub Actions"), but five call sites still relied on the default:Under cargo-tarpaulin (ptrace, unoptimised build)
rule_validate_variablesfails deterministically withRunLimit(Timeout), and the others are one slow runner away from the same. This is what keeps the Coverage job red once the biscuit-quote timeout is out of the way.Switch them to
authorize_with_limits/query_with_limitswith the same 10 s budget the neighbouring tests use. Verified with three consecutivecargo tarpaulin --workspace --exclude biscuit-quoteruns (89/89 lib tests pass); the same command on main fails.