Conversation
saoirse-a
force-pushed
the
block-builder-serialization
branch
from
August 13, 2026 11:34
3543fe8 to
b19ed37
Compare
Allows `BlockBuilder` to be serialized and deserialized, to save them for re-use or to transmit them across a process boundary (similar to `AuthorizerSnapshot`). `BlockBuilder` is serialized as a protobuf `Block` message with all of their symbols and public keys interned into this block.
divarvel
reviewed
Aug 16, 2026
| /// `BlockBuilder` is serialized as a self-contained biscuit block; it must carry its symbols | ||
| /// and public keys in its internment table. The block's contents are not authenticated. | ||
| /// [`ThirdPartyBlock`](crate::ThirdPartyBlock) instead. | ||
| pub fn from<T: AsRef<[u8]>>(slice: T) -> Result<Self, error::Token> { |
Contributor
There was a problem hiding this comment.
nit: I think from should be kept for From impls out of consistency. from_bytes might be more accurate here
Contributor
Author
|
Renamed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows
BlockBuilderto be serialized and deserialized, to save them for re-use or to transmit them across a process boundary (similar toAuthorizerSnapshot).BlockBuilderis serialized as a protobufBlockmessage with all of their symbols and public keys interned into this block.