Skip to content

Code cleanup #80

Description

@Geal

the library has been written in a way that is not very idiomatic, mainly through using types from the vavr project. This has helped us gain confidence in the implementation by following closely the rust implementation, but it is now slowing us down. Those types should be replaced gradually, where it makes sense (not a thoughtless search and replace):

  • Either -> using exceptions. This in particular should clean up a lot of the code
  • option: nullable type?
  • tuples -> record objects

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions