fix(ci): add @types/node for main and preload - #8
Merged
Conversation
CI build failed after #7 because main and preload tsconfigs did not declare Node types and @types/node was not installed, so tsc errored on every process/fs/path/process.env reference. Co-authored-by: opencode-agent <hello@sst.dev>
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
tsc ran before bun install, so @types/node was missing from node_modules when the build job reached the typecheck step. Co-authored-by: opencode-agent <hello@sst.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@types/nodedevDependency"types": ["node"]intsconfig.main.jsonandtsconfig.preload.jsonFixes the build failure on #7 (TS2304/TS7006/TS2591 on every Node API in
src/mainandsrc/preload).Testing
bunx tsc -p tsconfig.main.jsonbunx tsc -p tsconfig.preload.jsonmise run build