Repository navigation
The Maven plugin no longer timestamps by default (Fixes #366) - #367
Closed
iqdoq-dfischer wants to merge 1 commit into
Closed
iqdoq-dfischer wants to merge 1 commit into
iqdoq-dfischer wants to merge 1 commit into
Conversation
The default value of tsmode enabled the timestamping although neither tsaurl nor tsmode was configured. SignerHelper already falls back to Authenticode when tsmode is null.
Owner
|
Rebased and merged (059b8de) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #366.
The
tsmodeparameter ofJsignMojohaddefaultValue = "Authenticode". SinceSignerHelperenables timestamping whentsaurlortsmodeis set, the Maven plugin always timestamped, and no configuration could turn it off. The default is not needed:SignerHelperalready falls back toTimestampingMode.AUTHENTICODEwhentsmodeis null.With this change the Maven plugin behaves like the Ant task and the command line tool: it timestamps only when
tsaurlortsmodeis configured. A configuration that setstsaurlkeeps timestamping in Authenticode mode as before.JsignMojo: dropped the default value oftsmode, documented Authenticode as the default modeJsignMojoTest.testNoTimestampingByDefault: checks the generated plugin descriptor gives neithertsaurlnortsmodea default value (fails without the fix)README.md: entry in the 8.0 changesVerified:
JsignMojoTestpasses from a clean build, and a script signed with the 8.0-SNAPSHOT plugin and notsaurl/tsmodenow carries no time stamp.🤖 Generated with Claude Code