Skip to content

The Maven plugin no longer timestamps by default (Fixes #366) - #367

Closed
iqdoq-dfischer wants to merge 1 commit into
ebourg:masterfrom
iqdoq-dfischer:maven-tsmode-default
Closed

iqdoq-dfischer wants to merge 1 commit into
ebourg:masterfrom
iqdoq-dfischer:maven-tsmode-default

Conversation

@iqdoq-dfischer

Copy link
Copy Markdown
Contributor

Fixes #366.

The tsmode parameter of JsignMojo had defaultValue = "Authenticode". Since SignerHelper enables timestamping when tsaurl or tsmode is set, the Maven plugin always timestamped, and no configuration could turn it off. The default is not needed: SignerHelper already falls back to TimestampingMode.AUTHENTICODE when tsmode is null.

With this change the Maven plugin behaves like the Ant task and the command line tool: it timestamps only when tsaurl or tsmode is configured. A configuration that sets tsaurl keeps timestamping in Authenticode mode as before.

  • JsignMojo: dropped the default value of tsmode, documented Authenticode as the default mode
  • JsignMojoTest.testNoTimestampingByDefault: checks the generated plugin descriptor gives neither tsaurl nor tsmode a default value (fails without the fix)
  • README.md: entry in the 8.0 changes

Verified: JsignMojoTest passes from a clean build, and a script signed with the 8.0-SNAPSHOT plugin and no tsaurl/tsmode now carries no time stamp.

🤖 Generated with Claude Code

The default value of tsmode enabled the timestamping although neither
tsaurl nor tsmode was configured. SignerHelper already falls back to
Authenticode when tsmode is null.
@ebourg

ebourg commented Oct 10, 2026

Copy link
Copy Markdown
Owner

Rebased and merged (059b8de)

@ebourg ebourg closed this Oct 10, 2026
@ebourg ebourg modified the milestones: 8.0, 7.6 Oct 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Maven plugin always timestamps: tsmode defaultValue enables timestamping

2 participants