Repository navigation
Conversation
Owner
|
Thank you for the PR. What if a private CA uses AIA URLs on a private network (10.x.x.x, 192.168.x.x) ? |
Author
|
good point, blocking the whole private range would break a private CA serving its AIA urls from 10.x or 192.168.x. i've dropped the site-local check and kept only loopback, link-local (covers the 169.254.169.254 metadata endpoint), wildcard and multicast, so private networks stay reachable and the untrusted-cert case can't reach the local host or metadata service. dropped the 10.0.0.1 case from the test to match. |
Author
|
any update? |
Owner
|
Not yet, sorry, but I'll get a look |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
reject loopback/link-local/wildcard/multicast targets in HttpClient.connect before opening the connection (and on every redirect), so an untrusted certificate's AIA caIssuers url, fetched while CertificateChain.complete() completes the chain during verification, can't be used to reach the local host or the cloud metadata endpoint. private ranges (10.x, 172.16.x, 192.168.x) stay reachable so a private CA serving its AIA urls from there keeps working.