Performance improvement in OrmQueryProperties with immutable hash pre…#3762
Merged
Performance improvement in OrmQueryProperties with immutable hash pre…#3762
Conversation
zhangshifeng
reviewed
May 7, 2026
| return builder.toString(); | ||
| } | ||
|
|
||
| private static String buildImmutableQueryPlanHashSuffix(FetchConfig fetchConfig) { |
Contributor
There was a problem hiding this comment.
Should we put } in the suffix?
Member
Author
There was a problem hiding this comment.
Yes, although an alternative is to just include the immutableHashSuffix into the immutableHashPrefix. Hmm.
Member
Author
There was a problem hiding this comment.
Ah, scratch my thought ... the immutableHashSuffix needs to be separate, so yeah that ending } could go in there.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…fix and suffix