Repository navigation
Don't use two attributes for same purpose - #690
Closed
strengejacke wants to merge 1 commit into
Closed
strengejacke wants to merge 1 commit into
strengejacke wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Existing consumers misinterpret the consolidated metadata, causing incorrect labels, suppressed plot overlays, and stale transformation attributes.
4 open issues
What changed in this PR
Consolidates transformation metadata into a single transform attribute across modelbased outputs.
Changes:
- Removes duplicate
transform_argmetadata. - Updates prediction metadata and footer lookup.
- Increments the development version.
| File | Description |
|---|---|
| R/table_footer.R | Reads the consolidated transformation attribute. |
| R/get_marginalmeans.R | Consolidates means metadata and attribute documentation. |
| R/get_marginalcontrasts.R | Removes duplicate transformation metadata. |
| R/estimate_predicted.R | Preserves the original transformation argument in metadata. |
| DESCRIPTION | Bumps version to 0.17.0.19. |
Review effort: Balanced
| attributes(out) <- c( | ||
| attributes(out), | ||
| grid_specs[!names(grid_specs) %in% c(names(attributes(out)), "transform_arg")] | ||
| grid_specs[!names(grid_specs) %in% names(attributes(out))] |
| datagrid = datagrid, | ||
| transform = !is.null(transform), | ||
| transform_arg = transform_arg, | ||
| transform = transform_arg, |
| datagrid = datagrid, | ||
| transform = !is.null(transform), | ||
| transform_arg = transform_arg, | ||
| transform = transform_arg, |
| # emmeans), so we use the `transform` argument as passed by the user | ||
| if (predict == "link") { | ||
| predict <- .link_transform_label(info$transform_arg, model) | ||
| predict <- .link_transform_label(info$transform, model) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.