Skip to content

fix #713 #714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mattansb merged 1 commit into from
Oct 9, 2026
Merged

fix #713 #714

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion DESCRIPTION
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ Imports:
insight (>= 1.5.4),
parameters (>= 0.29.3),
performance (>= 0.18.2),
datawizard (>= 1.4.0),
datawizard (>= 1.4.00001),

@etiennebacher etiennebacher Oct 11, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This cannot work since "1.4.00001" is not on CRAN. This should be reverted and Remotes should be used instead:

Remotes:
    easystats/datawizard

@mattansb mattansb Oct 11, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We really should have the r-universe repos used in GH actions...

Thanks!

@etiennebacher etiennebacher Oct 11, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not necessarily, I think our current setup is useful since it also helps determine the order of CRAN releases (I think R CMD check or at least CRAN checks catch the presence of Remotes in DESCRIPTION).

@strengejacke strengejacke Oct 11, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think R CMD check or at least CRAN checks catch the presence of Remotes in DESCRIPTION

Win-Builder and CRAN checks do at least.

stats,
utils
Suggests:
Expand Down
14 changes: 14 additions & 0 deletions tests/testthat/test-rankES.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -283,4 +283,18 @@ test_that("kendalls_w", {
warns <- capture_warnings(W1 <- kendalls_w(m, ci = NULL))
expect_match(warns[1], "dropped")
expect_equal(W1, kendalls_w(m[, -1], ci = NULL, verbose = FALSE))

d <- data.frame(
y = OrchardSprays$decrease,
g = factor(OrchardSprays$treatment),
b = factor(OrchardSprays$rowpos)
)
d_ordered <- d[order(d$b, d$g), ]

w1 <- kendalls_w(tapply(d$y, list(d$b, d$g), identity), ci = NULL)
w2 <- kendalls_w(y ~ g | b, data = d_ordered, ci = NULL)
w3 <- kendalls_w(y ~ g | b, data = d, ci = NULL)

expect_identical(w2[[1]], w1[[1]])
expect_identical(w3[[1]], w1[[1]])
})
Loading