Repository navigation
Conversation
tttboy123
requested review from
ValentaTomas,
dobrac and
jakubno
as code owners
October 24, 2026 06:07
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refs #3695. This is a focused routing-cleanup safety fix found while investigating stale routes, not a complete fix for hard-node-loss recovery.
The publisher currently deletes by execution ID alone. A replacement VM lifecycle can retain the execution ID (for example, a resume-fresh checkpoint), so delayed cleanup from the old lifecycle can delete the replacement route. The publisher also only includes
lifecycle_idwhen network placement supplies it.Validation
The new assertions fail against the original catalog/publisher behavior and pass with this patch. Final publication validation uses Go 1.26.10 on Linux/arm64, real isolated Redis 8.2.2, and golangci-lint 2.14.0 with the full repository configuration:
Coverage includes exact-owner deletion, absent-key idempotence, each identity mismatch, same-execution replacement, malformed/missing/empty owner fields, Redis errors, legacy compatibility, unchanged raw value/absolute expiry on rejection, stop-before-insert, in-flight/ambiguous store outcomes, cleanup metrics, and the real Publisher-to-Redis old-stop/new-stop sequence.
Scope and rollout boundaries