Skip to content

chore(deps): bump certifi and uv - #4

Merged
OndrejDrapalik merged 3 commits into
mainfrom
chore/emudhra-trust-store-bump
Oct 23, 2026
Merged

OndrejDrapalik merged 3 commits into
mainfrom
chore/emudhra-trust-store-bump

Conversation

@ValentaTomas

@ValentaTomas ValentaTomas commented Oct 23, 2026 •

Copy link
Copy Markdown
Member

Moves certifi 2026.6.17 → 2026.10.19 in uv.lock and the release workflow's setup-uv pin 0.11.19 → 0.13.4 (the PyPI publish path) — the versions the eMudhra intermediate-CA disclosure lists as patched: https://emudhra.we-have-a-problem.com/. ci.yml has no uv pin and already runs the latest uv with the same uv sync --locked / build commands, so this PR's CI also exercises the newer uv on the release steps. Reviewers: check the lock diff is certifi only plus revision 3 → 5 (the format uv 0.13 writes, readable by the uv both workflows now run). Note the build job's twine check fails because the unpinned hatchling backend now writes Metadata-Version: 2.5, which the locked twine 6.2.0 rejects; this diff touches neither, so main should fail the same way (its last CI run was 2026-07-16), and it needs its own fix.

Update: 426e434 bumps twine 6.2.0 → 7.0.0 in uv.lock, which fixes that twine check failure here. twine 7.0.0 accepts Metadata 2.5. It is the only package the lock moves, because its packaging>=26.1 and rich>=14.3.3 requirements are already met.

certifi 2026.6.17 -> 2026.10.19 in uv.lock, and the release workflow's
setup-uv pin 0.11.19 -> 0.13.4 (ci.yml carries no pin and already runs the
latest uv). These are the versions https://emudhra.we-have-a-problem.com/
lists as patched.

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
@cursor

cursor Bot commented Oct 23, 2026 •

Copy link
Copy Markdown

PR Summary

Low Risk
Toolchain and transitive dependency bumps plus a patch release version; no application/runtime code changes.

Overview
Bumps the release workflow’s pinned uv from 0.11.19 to 0.13.4 and refreshes uv.lock (including lock revision format). The lock also updates certifi to a newer release cited for intermediate-CA fixes.

Release prep: project version 0.1.0 → 0.1.1, and dev twine is constrained to >=7.0.0 (lock resolves 7.0.0) so twine check on built wheels/sdists accepts Metadata-Version 2.5 from the current hatchling build backend.

Reviewed by Cursor Bugbot for commit 332b317. Bugbot is set up for automated code reviews on this repo. Configure here.

ValentaTomas and others added 2 commits October 23, 2026 01:57
The unpinned hatchling build backend now writes Metadata-Version 2.5, and
twine 6.2.0 pins packaging's list of valid versions at 2.4, so the build
job's `twine check` failed with "'2.5' is not a valid metadata version".
This fails on main as well. twine 7.0.0 accepts 2.5. Its packaging>=26.1
and rich>=14.3.3 requirements are already met by the lock (26.2, 15.0.0),
so twine is the only package that moves.
@OndrejDrapalik
OndrejDrapalik merged commit 73f1f9a into main Oct 23, 2026
9 checks passed
@ValentaTomas

Copy link
Copy Markdown
Member Author

Verified the build job failure and fixed it in 426e434.

It fails on main too, so this PR didn't cause it. I exported origin/main (3d4a0b2) and ran the build job's steps with uv 0.13.4 and UV_PYTHON=3.12: uv sync --locked --extra dev, uv run python -m build, uv run twine check dist/*. The wheel says Metadata-Version: 2.5, and twine 6.2.0 fails it with InvalidDistribution: Invalid distribution metadata: '2.5' is not a valid metadata version.

Cause. twine 6.2.0 overwrites packaging.metadata._VALID_METADATA_VERSIONS with a list that ends at "2.4". That happens even though the locked packaging 26.2 already knows 2.5. twine 7.0.0 (2026-07-27) removes the override: its changelog says "Fix uploading packages with metadata version 2.5" (pypa/twine#1317).

Fix. uv lock --upgrade-package twine (uv 0.13.4) moves twine 6.2.0 → 7.0.0 and nothing else. twine 7 needs packaging>=26.1 and rich>=14.3.3, and the lock already has 26.2 and 15.0.0. The lock diff is the twine version, sdist and wheel lines only. [build-system] and the workflows are unchanged.

Run on this branch with the fix (uv 0.13.4):

  • build job steps on Python 3.12 (as ci.yml) and 3.13 (as release.yml): uv sync --locked --extra dev, then uv run python -m build, then uv run twine check dist/*. Pass: wheel and sdist both PASSED, and the wheel is still Metadata-Version 2.5.
  • The rest of release.yml on 3.13: uv run pytest (72 passed, 3 live deselected), uv run ruff check e2b_adk tests examples and uv run mypy e2b_adk. Pass.
  • uv sync --locked --extra dev on 3.10 and 3.11: pass.

PR CI on 426e434 is all green on ubuntu with the latest uv: build passes, and so does lint-type-test on 3.10 through 3.13.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants