Repository navigation
Conversation
Collaborator
|
@yangshun Thank you so much for this will give it a good review tomorrow. Will there be a follow up for the |
Author
|
@AlexanderKaran Definitely! Do you want me to submit a separate PR for it or combined into this? If separate, should I do it now, or after this PR has been merged? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the official Void 1.8.0 React/Vite starter to the install, build, dev-server startup, dependency, and browser-baseline benchmarks. This implements the starter-first proposal in #683.
The starter was generated with:
It retains the generated welcome page, styles, assets, React Compiler setting, typed routes, and default Cloudflare build target.
voidand@void/reactare pinned to the same exact version. The package has an independent lockfile, a first-party dependency manifest, and a standalone workspace. The added type-check script and ignored benchmark artifacts are documented in the methodology.The build benchmark retains the complete Cloudflare build output for core-js scanning. An optional
browserBuildOutputDirlets the baseline scanner use only the browser assets, preserving the existing default for other starters. Void also gets the existing Temporal exclusion used for starters that bundle optional serialization support without serializing Temporal values.There is no runtime app in this PR. Results JSON is left to CI. The framework detail page, logos, and chart branding are deferred until the first published benchmark results, following the approach requested on #709; the methodology is updated here as required by the current contribution guide.
Validation with Node.js 24.22.1 and pnpm 11.1.1:
pnpm build:docsThe pinned e18e analyzer produces valid dependency statistics but its publint step exits with an error because the generated private starter has no package version. The CI workflow already tolerates analyzer exit codes, and the resulting JSON passes the strict artifact validator.
I can maintain Void's integration after merge, including dependency upgrades, benchmark failures, and methodology updates.