Repository navigation
Schema and Unit - #839
Merged
Merged
Schema and Unit#839
Conversation
Contributor
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
framework-performance | 7a5b585 | Commit Preview URL Branch Preview URL |
Nov 12 2026, 03:19 AM |
dreyfus92
reviewed
Nov 12, 2026
dreyfus92
left a comment
Member
There was a problem hiding this comment.
gave this a quick scan, it's a big one so i couldn't go through everything, but a few spot checks looked good 👍
two small thoughts, neither blocking:
- now that values carry their unit, keys like
installTimeMs/nodeModulesSizeBytesrepeat it, andbodySizeKbholdsKiB. might be cheaper to rename now than after more history piles up scalarWithUnituses.default(unit), so a runner that forgetsunitwould still pass validation. could drop the default if we want that to fail
Collaborator
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on changes coming to the table/chart components to make process formatted values and raw values easier I have updated result schemas. Every measurement now is represented like so
latency: {value: 2.22, unit: "ms" }. This will allow for better formatting later down the line and easier to handle benchmarks with multiple results using different units.