Skip to content

Schema and Unit - #839

Merged
AlexanderKaran merged 5 commits into
mainfrom
schema-and-unit
Nov 12, 2026
Merged

AlexanderKaran merged 5 commits into
mainfrom
schema-and-unit

Conversation

@AlexanderKaran

Copy link
Copy Markdown
Collaborator

Based on changes coming to the table/chart components to make process formatted values and raw values easier I have updated result schemas. Every measurement now is represented like so latency: {value: 2.22, unit: "ms" }. This will allow for better formatting later down the line and easier to handle benchmarks with multiple results using different units.

  • Updated base schema
  • Updated past resullts
  • Updated benchmark runners and their tests
  • Cleaned up some formatter and utils no longer needed
  • Updated doc consumers

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
framework-performance 7a5b585 Commit Preview URL

Branch Preview URL
Nov 12 2026, 03:19 AM

@dreyfus92 dreyfus92 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gave this a quick scan, it's a big one so i couldn't go through everything, but a few spot checks looked good 👍

two small thoughts, neither blocking:

  • now that values carry their unit, keys like installTimeMs / nodeModulesSizeBytes repeat it, and bodySizeKb holds KiB. might be cheaper to rename now than after more history piles up
  • scalarWithUnit uses .default(unit), so a runner that forgets unit would still pass validation. could drop the default if we want that to fail

@AlexanderKaran

Copy link
Copy Markdown
Collaborator Author

gave this a quick scan, it's a big one so i couldn't go through everything, but a few spot checks looked good 👍

two small thoughts, neither blocking:

  • now that values carry their unit, keys like installTimeMs / nodeModulesSizeBytes repeat it, and bodySizeKb holds KiB. might be cheaper to rename now than after more history piles up
  • scalarWithUnit uses .default(unit), so a runner that forgets unit would still pass validation. could drop the default if we want that to fail
  • I plan on updating keys in a follow up PR, did not want to make this one larger
  • Will do this in a follow up as well

@AlexanderKaran
AlexanderKaran merged commit 6aeaa59 into main Nov 12, 2026
97 checks passed
@AlexanderKaran
AlexanderKaran deleted the schema-and-unit branch November 12, 2026 03:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants