Skip to content

fix(share): clear the held Access id after a finished alias fold #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tieubao merged 1 commit into from
Oct 6, 2026
Merged

fix(share): clear the held Access id after a finished alias fold #47

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions bin/share
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4144,6 +4144,7 @@ cmd_setup_tenant() { # cmd_setup_tenant <bucket> <storage_default> <force> [alia
[[ -n $gid ]] || continue
access_gate "$gid" "$gaud" || { alias_dests undo || true; die "Cloudflare Access did not enforce on $host_name/$gid within ${access_wait}s; the added destinations were removed; the route is not attached; rerun the same setup (or DELETE the v:2 pointers written so far)"; }
done <<<"$alias_moved"
held_access_id="" # every folded app enforced, so nothing waits in access-pending
echo "access: $(grep -c . <<<"$fold_apps") gated link(s) also gated at $host_name"
fi

Expand Down
1 change: 1 addition & 0 deletions tests/share.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3269,6 +3269,7 @@ row14end="{\"v\":1,\"host\":\"ten.example.test\",\"aliases\":[\"f.example.test\"
afresh
out=$(afold 2>&1); rc=$?
check "row 14: the fold exits 0" "0" "$rc"
check "row 14: a finished fold prints no stale access-pending notice" "0" "$(grep -c 'nothing was published' <<<"$out")"
check "row 14: the call order" "1" "$(vord "^GET app $fu1\$" '^API PUT /accounts/acct-dry/workers/scripts/share-ten-example-test$' '^PUT m/0a000' "^PUT app $fu1\$" '^PROBE ' '^CONFIG r2 on$' \
'^PUT share.json$' '^API POST /zones/zone-dry/workers/routes$' '^API PUT /accounts/acct-dry/workers/domains$' '^HEALTHZ$' '^ALIAS-301 f.example.test$')"
check "row 14: the alias destinations are dropped last, after the 301" "1" "$([[ $(grep -n "^PUT app $fu1\$" "$vlog" | tail -1 | cut -d: -f1) -gt $(grep -n '^ALIAS-301' "$vlog" | tail -1 | cut -d: -f1) ]] && echo 1 || echo 0)"
Expand Down
Loading