Repository navigation
fix(wrap): land waits 300s for late pull_request checks - #947
Merged
Merged
Conversation
tieubao
added a commit
that referenced
this pull request
Oct 9, 2026
* fix(wrap): land waits 300s for late pull_request checks * docs(verification): land register wait proof
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(wrap): land waits 300s for late pull_request checks
Proof of done
From
docs/verification/wrap-land-register-wait.md:Verification -- wrap-land-register-wait
wrap landmerged dwarvesf/share#47 before itspull_requestCI run existed. The register hold was 30s; GitHub queued the run 190s after the PR opened.Root cause evidence (gh, share#47): PR created 14:19:40Z, merged 14:20:19Z (39s). The
pull_requestrun 37478462017 was created 14:22:50Z (3m10s after open, 2m31s after the merge) and its checks started 14:23:26Z. The workflow trigger was detected correctly; the gate armed and gave up afterKIT_WRAP_LAND_GRACE_SECS(30).Lane: bug. Files:
lib/wrap/wrap-land.sh,tests/test-wrap-land.sh,lib/config/module-registry.md,commands/wrap.md,docs/CHANGELOG.md.Green run
pr merge(the share#47 shape)paths:-filtered workflow that starts nothing: at most 5 rollup reads, mergesno checks registered on #42 after, then merges as beforebash tests/run-all.shran 26 suites, all ok excepttest-config-registry, which fails the same way on unmodified master (ORPHAN: DWARVES_BOARD_CONFIG,DWARVES_HERMES_LINKS, board knobs unrelated to this change).Negative control
Not proven
ghis stubbed, so real registration latency is taken from the share#47 timestamps above.paths:/paths-ignore:/labeledin the workflow file. Apaths:underpush:reads as a PR filter (short grace, the old behaviour).[skip ci]head) now waits 300s once, then says so and merges.