Skip to content

fix(components): fixed Notification and Tabs accessing Button i… #331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ascartabelli merged 1 commit into from
Jun 3, 2026
Merged

fix(components): fixed Notification and Tabs accessing Button i… #331

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/bold-swans-join.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@duskit/components": patch
---

fix(components): fixed `Notification` and `Tabs` accessing `Button` internals in their CSS
5 changes: 5 additions & 0 deletions .changeset/every-ads-film.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@duskit/css": patch
---

Updated the `--interactive-action-naked-bg-hover-color` contract to use a non-transparent colour.
20 changes: 10 additions & 10 deletions packages/components/src/notification/Notification.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,18 +80,18 @@
flex: 1;
}

.dusk-notification__header .dusk-button--variant--naked {
--interactive-action-naked-text-color: var(--_header-text);
--interactive-action-naked-bg-hover-color: color-mix(
in srgb,
var(--_header-text) 15%,
transparent
.dusk-notification__btn-mark-as-read,
.dusk-notification__btn-dismiss {
padding: min(
var(--feedback-box-compact-padding-block),
var(--feedback-box-compact-padding-inline)
);
--interactive-action-naked-text-hover-color: var(--_header-text);

padding: 0;
border: 0;
aspect-ratio: 1;

&,
&:is(:enabled:hover, :enabled:active) {
color: var(--_header-text);
}
}

.dusk-notification__body {
Expand Down
7 changes: 5 additions & 2 deletions packages/components/src/tabs/Tabs.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,11 @@
gap: var(--interactive-control-compact-gap);
}

.dusk-button.dusk-icon-button.dusk-tab-scroll-button {
padding: 0;
.dusk-tab-scroll-button {
padding: min(
var(--interactive-control-compact-padding-block),
var(--interactive-control-compact-padding-inline)
);
border: 0;
}

Expand Down
6 changes: 5 additions & 1 deletion packages/css/src/3-categories/interactive.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,11 @@

/* Naked action */
--interactive-action-naked-bg-color: transparent;
--interactive-action-naked-bg-hover-color: transparent;
--interactive-action-naked-bg-hover-color: color-mix(
in srgb,
currentcolor 15%,
transparent
);
--interactive-action-naked-border-color: transparent;
--interactive-action-naked-border-hover-color: transparent;
--interactive-action-naked-text-color: currentcolor;
Expand Down
Loading